commented on pull request TDE/tdeedu#7
PR for issue 6 - enable kig python scripting for cmake build
OK on my Slackware installation with python 2.7, cmake 3.10, and boost 1.67.0.
A comment though ..
Using KIG_ENABLE_PYTHON_SCRIPTING enables kig to be built with or without python scripting support, but **tde_message_fatal( "Boost is required, but was not found on your system" )** causes a build failure if libboost_python isn't found.
In that case, KIG_ENABLE_PYTHON_SCRIPTING is redundant because in any build, it will only ever be 1.
So, either retain the option of building kig without python scripting support:
**- tde_message_fatal( "Boost is required, but was not found on your system" )**
**+ message( "Boost_python was not found on your system.\nkig will be built without Python Scripting support." )**
Or, remove the KIG_ENABLE_PYTHON_SCRIPTING definitions from the source code, enabling the enclosed code always, and then the KIG_ENABLE_PYTHON_SCRIPTING entries in config.h.cmake and ConfigureChecks.cmake aren't needed.
5 months ago