Fix GCC visibility, use common tests in CMake rules #1

Merged
SlavekB merged 1 commits from feat/cmakeCommonTests into master 5 years ago
Owner

In Akode I added the usual option WITH_GCC_VISIBILITY and the new common test tde_setup_gcc_visibility. The previous code only set __KDE_HAVE_GCC_VISIBILITY but did not set the compiler options at all. GCC visibility has therefore not been used properly. That's why I checked and added the use of AKODE_EXPORT to the exported functions in each plug-in.

Please test it.

Note: For test you need to build with WITH_ALL_OPTIONS or WITH_GCC_VISIBILITY.

In Akode I added the usual option WITH_GCC_VISIBILITY and the new common test tde_setup_gcc_visibility. The previous code only set __KDE_HAVE_GCC_VISIBILITY but did not set the compiler options at all. GCC visibility has therefore not been used properly. That's why I checked and added the use of AKODE_EXPORT to the exported functions in each plug-in. Please test it. Note: For test you need to build with WITH_ALL_OPTIONS or WITH_GCC_VISIBILITY.
SlavekB closed this pull request 5 years ago
SlavekB deleted branch feat/cmakeCommonTests 5 years ago
SlavekB added this to the R14.0.6 release milestone 5 years ago
The pull request has been merged as 68b71ec34c.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/akode#1
Loading…
There is no content yet.