Labels Milestones

Fix bug #2056, amarok does not rely anymore on pkg-config #11

Manually merged

Ghost merged 1 commits from bug/2056/ruby-detection into master 4 years ago

Conversation 2 Commits 1 Files Changed 1

SlavekB commented 4 years ago

Owner

Based on TDE/tdebindings commit 1aaf11f05e – adapted for Amarok.

Successfully tested on Debian 10 (Buster) and Debian 7 (Wheezy).

Please test on your distributions.

Based on TDE/tdebindings commit [1aaf11f05e](../tdebindings/commit/1aaf11f05e12e72cff263c13a28964dabc5dcf7a) – adapted for Amarok. Successfully tested on Debian 10 (Buster) and Debian 7 (Wheezy). <br/>Please test on your distributions.

Ghost commented 4 years ago

Build fine here (Slackware64-current, Ruby-2.6.5).

@SlavekB as a side note, to my knowledge, Debian does not provide mp4v2 (which is a dependency) anymore ; as a result you have to provide It as an extra package but there's no support from upstream to mp4v2.

One option is to switch to the TechSmith mp4v2's fork https://github.com/TechSmith/mp4v2 (NetBSD in pkgsrc did that already http://pkgsrc.se/multimedia/mp4v2 ).

I've built Amarok with https://github.com/TechSmith/mp4v2/releases/tag/Release-MP4v2-3.0.4.0 , further testing might be in order with Amarok to check if everything works as expected but at least It builds!

Build fine here (Slackware64-current, Ruby-2.6.5). @SlavekB as a side note, to my knowledge, Debian does not provide mp4v2 (which is a dependency) anymore ; as a result you have to provide It as an extra package but there's no support from upstream to mp4v2. One option is to switch to the TechSmith mp4v2's fork https://github.com/TechSmith/mp4v2 (NetBSD in pkgsrc did that already http://pkgsrc.se/multimedia/mp4v2 ). I've built Amarok with https://github.com/TechSmith/mp4v2/releases/tag/Release-MP4v2-3.0.4.0 , further testing might be in order with Amarok to check if everything works as expected but at least It builds!

SlavekB commented 4 years ago

Poster

Owner

Thank you for testing.

Nothing seems to prevent merge.

Thank you for testing. <br/>Nothing seems to prevent merge.

SlavekB closed this pull request 4 years ago

Ghost closed this pull request 4 years ago

SlavekB deleted branch bug/2056/ruby-detection 4 years ago

SlavekB added this to the R14.0.7 release milestone 4 years ago

The pull request has been manually merged as 2d6d94a45c.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce

No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme

Milestone

Set milestone

Clear milestone

No items

No Milestone

R14.0.7 release

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/amarok#11

Write Preview

Loading…

Cancel

Save

There is no content yet.