Conversion to the cmake building system #10
Συγχωνευμένα
SlavekB
συγχώνευσε 1 υποβολές από feat/cmakeUpdate σε master 4 έτη πριν
Δεν υπάρχουν εξεταστές
Χωρίς Σήμα
Χωρίς Αποδέκτη
4 Συμμετέχοντες
Ειδοποιήσεις
Ημερομηνία Παράδοσης
Δεν ορίστηκε ημερομηνία παράδοσης.
Εξαρτήσεις
Δεν έχουν οριστεί εξαρτήσεις.
Αναφορά: TDE/amarok#10
Φόρτωση…
Αναφορά σε νέο ζήτημα
Δεν υπάρχει ακόμα περιεχόμενο.
Διαγραφή του Κλάδου 'feat/cmakeUpdate'
Η διαγραφή του κλάδου είναι μόνιμη. ΔΕΝ ΜΠΟΡΕΙ να αναιρεθεί. Συνέχεια;
Sqlite-3.4.1 has CVE, if possible see to upgrade included Sqlite or go full external linkage and delete the folder.
Some folders in metadata don't seem to be processed even with the automake build --> to check ==> to delete.
NMM and Helix engines haven't been supported for a while ==> delete folders.
Welcome Greg!! 😃
Hi Michele ;-)
Included Sqlite has been upgraded to 3.4.2, sources taken from here:
https://src.fedoraproject.org/lookaside/pkgs/sqlite/sqlite-3.4.2.tar.gz/2feec9b429f9298c9f288420c8b449f8/
Built like this:
./configure --enable-threadsafe && make sqlite3.c
then I copied sqlite3.c and sqlite3.h into Amarok's sqlite folder.
Guys, if you know better how to upgrade Sqlite, please, step in.
Note: For MySQL we will need to add a test of the name of the MySQL client main structure – see commit
7b0045aa6b.@SlavekB ok!
Rem...probably don't need TDE includes and libs for sqlite3 embedded. done!
Rem..add thread libs... done!
autotools config test:
result:
The detection and the building of the DAAP module (Ruby stuff) is fine with Ruby's series 1.8 up to 2.1 ; albeit some deprecated show up in the 2.1 serie:
The config process fails, starting with Ruby-2.2 with this error:
Should work with something like that: --> ok, from ruby 1.8 to 2.2
Rem...cleanup ConfigureChecks.cmake daap...done!
Building with gcc visilility "ON", FTBFS with this error:
I pushed a little change into your branch:
This should fix the above problem.
I get this new kind of error:
Added
LIBAMAROK_EXPORTon namespaces indebug.h. Please try if it solve the problem above and we move forward 😺Still get FTBFS with gcc visilibily:
Rem...loader.cpp qt=> tqt and kde=>tde
Rem...to add man pages.
see if It's relevant to add more unwanted extensions in xine (xine-engine.cpp L670)
TDE_VERSION in magnatunelistview.cpp --> check
DNSSD_SUPPORT is a KDE_IS_VERSION macro (daap)
crashhandler.cpp L222 kapp->invokeMailer
Rem...fill in
{MP4V2_INCLUDE_DIRS} and{MP4V2_LIBRARY_DIRS}, change mp4v2...done!Interestingly when I lunch kiosktool --help-tde ,
the command displays Its options but when I do the same with amarok (amarok --help-tde), I get this error:
Yes, for me too.
But using:
works fine here. 😺
Greg, please take note of #14 which has just been merged. You may have to do some small tweaking to your PR now.
@cethyel I suppose I'll take care of the merger of the conflicts that arised from #14.
I've had my fill with this PR as a result I don't intend to work further on It. Slávek, feel free to merge/solve with last Amarok commits if you intend to complete this work/update on cmake builds or let It be an archive (like I do) for those willing to either take over or profit from.
@cethyel you can be sure that your excellent work on CMake conversion won't stay unfinished here! I hope to find time to solve the remaining hidden visibility problems soon. It is now rebased on the current HEAD.
I did a test to build on Debian 7.x (Wheezy) – it required a fix typo in Ruby detection, and on Ubuntu 20.04 (Focal) – it required a fix of MySQL structure detection.
Now I did a functional test: Amarok plays, shows a collection (sqlite), shows track information, everything seems to be fine. However, there is one problem. I've tried installing aKode-engine, but it's not in the engines list, so it's not possible to use it.
Later I found another problem: Visualization doesn't work – no plugin is offered, just information that libvisual is not available.
Note: I tried to build amarok without hidden visibility to verify that the aKode-engine and amarok-visual problem are related to hidden visibility. And the result is that this is not the cause – both problems persisted.
Amarok-visual problem solved – libvisual-0.4-plugins package was not installed on my home machine 😺
Problem with unavailability of aKode engine resolved – there was set
X-TDE-Amarok-rank=0, which means disabled.However, the possibilities seem to be limited. On my system, it won't play mp3. And I don't know if it's also related to mp3, but it won't play my favorite internet radio. The question here may be whether it makes sense to provide such an engine as a deb package.
If Akode is built with ffmpeg support does this change anything?
Greg, good point – I installed libakode2-mpeg and mp3 now play! Thank you. However, Internet radio still cannot be played with aKode.
Because everything looks good, I did squash all fixes to CMake conversion into one commit and hidden visibility fixes into one commit.
Now, nothing seems to prevent merging.
Greg, you did a great job!
WIP: conversion to the cmake building systemσε Conversion to the cmake building system 4 έτη πρινNote:
WITH_GCC_VISIBILITYchanged fromOFFto${WITH_ALL_OPTIONS}I've tried CMake building on FreeBSD, and the result is one more revision of the commit regarding hidden visibility. It was advantageous that I haven't done a merge yet!
16ec57d25f.