Fixed FTBFS with xine 1.2.10. #18

Manually merged
MicheleC merged 1 commits from bug/3065-3066 into master 4 years ago
Owner

The use of the xine scope plugin is currently disabled when xine >= 1.2.10 is detected.
This resolves bug 3065 and 3066.

Additional info:
The xine scope plugin is statically linked and therefore written by
accessing internal xine data that are no longer publicly available from
xine 1.2.10.
To add back the scope plugin functionality, the plugin will have to be
converted into a dynamically linked one and further work done to fix the
logic of the plugin itself.


Amarok now works fine with xine 1.2.10 but the scope plugin is lost. Could you please test in older distros and make sure amarok works fine and so does the scope plugin too?

The use of the xine scope plugin is currently disabled when xine >= 1.2.10 is detected. This resolves bug 3065 and 3066. Additional info: The xine scope plugin is statically linked and therefore written by accessing internal xine data that are no longer publicly available from xine 1.2.10. To add back the scope plugin functionality, the plugin will have to be converted into a dynamically linked one and further work done to fix the logic of the plugin itself. --------------- Amarok now works fine with xine 1.2.10 but the scope plugin is lost. Could you please test in older distros and make sure amarok works fine and so does the scope plugin too?
MicheleC added this to the R14.0.9 release milestone 4 years ago
SlavekB approved these changes 4 years ago
SlavekB left a comment
Owner

Everything is fine – as expected. When building with an older version of Xine, the build is successful and the scope plugin works.

Everything is fine – as expected. When building with an older version of Xine, the build is successful and the scope plugin works.
MicheleC closed this pull request 4 years ago
SlavekB deleted branch bug/3065-3066 4 years ago
Poster
Owner

Thanks for testing Slavek!

Thanks for testing Slavek!
The pull request has been manually merged as f643355717.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/amarok#18
Loading…
There is no content yet.