Port ioctl prototype check to CMake #3
Merged
MicheleC
merged 2 commits from feat/fix-ioctl-prototype-check
into master
4 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'feat/fix-ioctl-prototype-check'
Deleting a branch is permanent. It CANNOT be undone. Continue?
realted to TDE/arts#2
This looks very good – like the right solution to replace pull request #2.
I am going to test your PR in a moment. BTW, just one detail; unsigned long and unsigned long int are the same thing (I don't know if you want to preserve both here)
@selk "unsigned long int" v.s. "unsigned long" is the questional and WIP point.
I don't know the historical reason why aRts introduced the check.
Far as I can see, it is safe to remove unsigned long int:
I recently tested your (WIP) patch under Musl and it worked. :-)
MicheleC referenced this pull request 4 years agohttps://mirror.git.trinitydesktop.org/gitea/TDE/arts/src/branch/master/artsc/artsdsp.c#L78
long and long int are the same data type. I suggest we drop long int and update this PR and arts code accordingly so that we have only HAVE_IOCTL_INT_INT_DOTS and HAVE_IOCTL_INT_ULONG_DOTS.
Any feedback is welcome.
Just only HAVE_IOCTL_INT_ULONG_DOTS is sufficient, others should be the standard compliance?
Tests 1 –
HAVE_IOCTL_INT_INT_DOTS
and 2 –HAVE_IOCTL_INT_ULONG_DOTS
are necessary. Test 3 –HAVE_IOCTL_INT_ULONGINT_DOTS
seems to be actually the same as 2, becauselong
andlong int
determine the same thing.Therefore, it seems that we can exclude test 3 as well as the condition in artsc/artsdsp.c.
WIP: Port ioctl prototype check to CMaketo Port ioctl prototype check to CMake 4 years agochanged as suggested
It looks good. 👍
perfect, thanks!
08329d9014
.