TDE
/
codeine
2
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
Labels Milestones

Fixed xine scope plugin functionality with xine 1.2.10. #3

Merged
MicheleC merged 1 commits from issue/scope-plugin into master 4 years ago
Conversation 0 Commits 1 Files Changed 3
MicheleC commented 4 years ago
Owner

As per title. Please test in distros with xine < 1.2.10.

The plugin is built and used but not sure of what it does... I can't see any visual feedback when playing a song.

As per title. Please test in distros with xine < 1.2.10. The plugin is built and used but not sure of what it does... I can't see any visual feedback when playing a song.
MicheleC added the PR/rfc label 4 years ago
MicheleC requested review from SlavekB 4 years ago
MicheleC added this to the R14.0.9 release milestone 4 years ago
SlavekB reviewed 4 years ago
SlavekB left a comment
Owner

Build done successfully on Wheezy. Only there is a question to consider – see the comment.

Build done successfully on Wheezy. Only there is a question to consider – see the comment.
src/app/xineEngine.cpp Outdated
#include "slider.h"
#include "theStream.h"
#include "xineEngine.h"
extern "C"
SlavekB commented 4 years ago
Owner

Would it make sense to move extern "C" inside xineScope.h?

Would it make sense to move `extern "C"` inside `xineScope.h`?
MicheleC commented 4 years ago
Poster
Owner

I did tried that already and this is what I got

In file included from /home/tde_src/2_build/build/applications/codeine/src/app/xineScope.c:7:
/home/tde_src/2_build/build/applications/codeine/src/app/xineScope.h:16:8: error: expected identifier or ‘(’ before string constant
   16 | extern "C"

No evident syntax error in the code (like missing parenthesis).

xineScope.c is a C file. xineEngine.cpp is a C++ file. That is where the problem comes from.

An alternative solution would be to transform the scope file to a C++ file.

I did tried that already and this is what I got ``` In file included from /home/tde_src/2_build/build/applications/codeine/src/app/xineScope.c:7: /home/tde_src/2_build/build/applications/codeine/src/app/xineScope.h:16:8: error: expected identifier or ‘(’ before string constant 16 | extern "C" ``` No evident syntax error in the code (like missing parenthesis). xineScope.c is a C file. xineEngine.cpp is a C++ file. That is where the problem comes from. An alternative solution would be to transform the scope file to a C++ file.
SlavekB commented 4 years ago
Owner

There will be necessary:

#ifdef __cplusplus
extern "C"
{
#endif
#include <xine/xine_plugin.h>
#ifdef __cplusplus
}
#endif
There will be necessary: ``` #ifdef __cplusplus extern "C" { #endif #include <xine/xine_plugin.h> #ifdef __cplusplus } #endif ```
MicheleC commented 4 years ago
Poster
Owner

nice, thanks Slavek!

nice, thanks Slavek!
src/app/xineScope.h Outdated
#include <sys/types.h>
#include <xine/metronom.h>
#include <xine/xine_plugin.h>
SlavekB commented 4 years ago
Owner

If extern "C" were used here, then using include "xineScope.h" would be without special care.

If `extern "C"` were used here, then using `include "xineScope.h"` would be without special care.
MicheleC marked this conversation as resolved
SlavekB approved these changes 4 years ago
SlavekB left a comment
Owner

Successfully tested building on Wheezy and Bullseye.
Good work, thank you.

Successfully tested building on Wheezy and Bullseye. Good work, thank you.
MicheleC merged commit 304d3a226c into master 4 years ago
MicheleC deleted branch issue/scope-plugin 4 years ago
MicheleC removed the PR/rfc label 4 years ago

Reviewers

SlavekB approved these changes 4 years ago
The pull request has been merged as 304d3a226c.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.9 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/codeine#3
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'issue/scope-plugin'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes