Add a couple of missing icons. #4

few icons were missing during the kde3 to TDE env conversion.

This refers to screenshot Screenshot_2020-07-02_12-50-58.png

A small note: Here we will have to be careful for the backport r14.0.x branch, because some changes are related to the change of icons in the master branch.

...Here we will have to be careful for the backport r14.0.x branch...

Them we might brand this PR for Milestone R14.1.0 (and onward) only.

We just need to be careful with the names in backporting to R14.0.9. I will take or that, no problem.

@cethyel Could you rebase on top of master branch? That way your GPG signature will be retained 😉

@MicheleC I'll be back on this next week.

@MicheleC I'll be back on this next week.

No problem, let me know when ready and I will check then 👍

@MicheleC I didn't build with tdelibs-R14.0.x branch, nonetheless I believe the differences between tdelibs-master and tdelibs-R14.0.x are the following:

media-optical-cdaudio-unmounted --> media-optical-cdaudio
media-optical-dvd-unmounted --> media-optical-dvd

the commit has been rebased too.

brought an other icon back, player_mute, this refers to screenshot: Screenshot_2020-07-02_12-57-03.png

After checking, It appears that the player_mute icon is not part of tdelibs but from kaffeine (hi22-action-player_mute.png). We might just move that icon in tdelibs's pics folder.

NB: The look of this icon should reflects that the sound is muted because when the slider goes up, the sound decreases.

@MicheleC I didn't build with tdelibs-R14.0.x branch, nonetheless I believe the differences between tdelibs-master and tdelibs-R14.0.x are the following:

media-optical-cdaudio-unmounted --> media-optical-cdaudio
media-optical-dvd-unmounted --> media-optical-dvd

the commit has been rebased too.

Thanks Greg, I will check it out

NB: The look of this icon should reflects that the sound is muted because when the slider goes up, the sound decreases.

This sounds weird. I will do further checking in Lenny as comparison.

NB: The look of this icon should reflects that the sound is muted because when the slider goes up, the sound decreases.

This sounds weird. I will do further checking in Lenny as comparison.

Hi Greg,
the volume slider invoked by pressing "1" seems not to work at all (even in Lenny + KDE 3.5.10), so rather than using a mute icon for the "volume" entry, we shall fix the slider instead.

The remaining two icons looks good.

Please remove (or adjust) the part related to the volume icon. Then rebase (again - sorry) on top of the current master so your GPG singature will be preserved and we will be ready to merge. We can fix the slider functionality separately.

@MicheleC Have you gotten back all 5 icons with this PR?
Screenshot reference: Screenshot_2020-07-02_12-50-58.png

If so I'll remove wip.

Yes, all 5 icons are there, same as in the screenshot you referenced. Good job.

We can merge this PR if you have no other obejctions.

Yes, all 5 icons are there, same as in the screenshot you referenced. Good job.

We can merge this PR if you have no other obejctions.

before you merge, do you have tdeartwork and/or kaffeine installed?

before you merge, do you have tdeartwork and/or kaffeine installed?

As discussed on IRC, without tdeartwork and kaffeine, the icons are still showing up correctly.

Sorry, I messed up the backport to R14.0.x. I needed one extra commit to clean it up.