Fixed xine scope plugin functionality with xine 1.2.10. #3
Merged
MicheleC
merged 1 commits from issue/scope-plugin
into master
4 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'issue/scope-plugin'
Deleting a branch is permanent. It CANNOT be undone. Continue?
As per title. Please test in distros with xine < 1.2.10.
The plugin is built and used but not sure of what it does... I can't see any visual feedback when playing a song.
Build done successfully on Wheezy. Only there is a question to consider – see the comment.
#include "slider.h"
#include "theStream.h"
#include "xineEngine.h"
extern "C"
Would it make sense to move
extern "C"
insidexineScope.h
?I did tried that already and this is what I got
No evident syntax error in the code (like missing parenthesis).
xineScope.c is a C file. xineEngine.cpp is a C++ file. That is where the problem comes from.
An alternative solution would be to transform the scope file to a C++ file.
There will be necessary:
nice, thanks Slavek!
#include <sys/types.h>
#include <xine/metronom.h>
#include <xine/xine_plugin.h>
If
extern "C"
were used here, then usinginclude "xineScope.h"
would be without special care.Successfully tested building on Wheezy and Bullseye.
Good work, thank you.
304d3a226c
into master 4 years agoReviewers
304d3a226c
.