#19 Code generated for signals use wrong direction.

Closed
opened 1 month ago by MicheleC · 3 comments
MicheleC commented 1 month ago

With reference to https://mirror.git.trinitydesktop.org/gitea/deloptes/dbus-1-tqt-example/src/branch/master/4e, the code generated for the two signals in ObjectManager have the wrong direction. They should be “out” signals, but the generated code says they are “in” signals. This caused the service to not be displayed properly in d-feet. See discussion in #7 for further details.

With reference to https://mirror.git.trinitydesktop.org/gitea/deloptes/dbus-1-tqt-example/src/branch/master/4e, the code generated for the two signals in ObjectManager have the wrong direction. They should be "out" signals, but the generated code says they are "in" signals. This caused the service to not be displayed properly in d-feet. See discussion in #7 for further details.
deloptes commented 1 month ago
Collaborator

As mentioned in #7, when this was discovered, even if one sets direction=“out” in the xml specification, it still generates the code with direction “in”.

The default direction for a signal should be always “out”.

As mentioned in #7, when this was discovered, even if one sets direction="out" in the xml specification, it still generates the code with direction "in". The default direction for a signal should be always "out".
MicheleC added this to the R14.1.0 release milestone 1 month ago
MicheleC commented 4 weeks ago
Owner

Hi Emanoil, during my lunch break I took a look at your PR. It works correctly but there are some unnecessary code changes.
I have prepared PR #22 partially based on your work: this also improves code related to signal emission, which is only called (and supposed to be called) for signals, no methods. Please review and let me know what you think.

Hi Emanoil, during my lunch break I took a look at your PR. It works correctly but there are some unnecessary code changes.<br> I have prepared PR #22 partially based on your work: this also improves code related to signal emission, which is only called (and supposed to be called) for signals, no methods. Please review and let me know what you think.
MicheleC commented 3 weeks ago
Owner

Solved by PR #22.

Solved by PR #22.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.