Code generated for signals use wrong direction. #19
Closed
opened 5 years ago by MicheleC
·
3 comments
No Label
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: TDE/dbus-1-tqt#19
Loading…
Reference in new issue
There is no content yet.
Delete Branch '%!s(<nil>)'
Deleting a branch is permanent. It CANNOT be undone. Continue?
With reference to https://mirror.git.trinitydesktop.org/gitea/deloptes/dbus-1-tqt-example/src/branch/master/4e, the code generated for the two signals in ObjectManager have the wrong direction. They should be "out" signals, but the generated code says they are "in" signals. This caused the service to not be displayed properly in d-feet. See discussion in #7 for further details.
As mentioned in #7, when this was discovered, even if one sets direction="out" in the xml specification, it still generates the code with direction "in".
The default direction for a signal should be always "out".
Hi Emanoil, during my lunch break I took a look at your PR. It works correctly but there are some unnecessary code changes.
I have prepared PR #22 partially based on your work: this also improves code related to signal emission, which is only called (and supposed to be called) for signals, no methods. Please review and let me know what you think.
Solved by PR #22.