Code generated for signals use wrong direction. #19

닫힘
MicheleC5 년 전을 오픈 · 3개의 코멘트
MicheleC 코멘트됨, 5 년 전
소유자

With reference to https://mirror.git.trinitydesktop.org/gitea/deloptes/dbus-1-tqt-example/src/branch/master/4e, the code generated for the two signals in ObjectManager have the wrong direction. They should be "out" signals, but the generated code says they are "in" signals. This caused the service to not be displayed properly in d-feet. See discussion in #7 for further details.

With reference to https://mirror.git.trinitydesktop.org/gitea/deloptes/dbus-1-tqt-example/src/branch/master/4e, the code generated for the two signals in ObjectManager have the wrong direction. They should be "out" signals, but the generated code says they are "in" signals. This caused the service to not be displayed properly in d-feet. See discussion in #7 for further details.
deloptes 코멘트됨, 5 년 전
협업자

As mentioned in #7, when this was discovered, even if one sets direction="out" in the xml specification, it still generates the code with direction "in".

The default direction for a signal should be always "out".

As mentioned in #7, when this was discovered, even if one sets direction="out" in the xml specification, it still generates the code with direction "in". The default direction for a signal should be always "out".
MicheleC R14.1.0 release 5 년 전 마일스톤을 추가하였습니다.
MicheleC 코멘트됨, 5 년 전
포스터
소유자

Hi Emanoil, during my lunch break I took a look at your PR. It works correctly but there are some unnecessary code changes.

I have prepared PR #22 partially based on your work: this also improves code related to signal emission, which is only called (and supposed to be called) for signals, no methods. Please review and let me know what you think.

Hi Emanoil, during my lunch break I took a look at your PR. It works correctly but there are some unnecessary code changes.<br> I have prepared PR #22 partially based on your work: this also improves code related to signal emission, which is only called (and supposed to be called) for signals, no methods. Please review and let me know what you think.
MicheleC 코멘트됨, 5 년 전
포스터
소유자

Solved by PR #22.

Solved by PR #22.
MicheleC closed this issue 5 년 전
로그인하여 이 대화에 참여
마일스톤 없음
담당자 없음
참여자 2명
알림
마감일

마감일이 설정되지 않았습니다.

의존성

No dependencies set.

Reference: TDE/dbus-1-tqt#19
불러오는 중...
아직 콘텐츠가 없습니다.