Code generated for signals use wrong direction. #19
Slēgta
MicheleC atvēra pirms 5 gadiem
·
3 komentāri
Nav etiķešu
Nav atbildīgo
2 dalībnieki
Paziņojumi
Izpildes termiņš
Izpildes termiņš nav uzstādīts.
Atkarības
Nav atkarību.
Atsaucas uz: TDE/dbus-1-tqt#19
Notiek ielāde…
Atsaukties uz šo jaunā problēmā
Vēl nav satura.
Dzēst atzaru '%!s(<nil>)'
Atzara dzēšana ir neatgriezeniska, kā arī tā ir NEATGRIEZENISKA. Vai turpināt?
With reference to https://mirror.git.trinitydesktop.org/gitea/deloptes/dbus-1-tqt-example/src/branch/master/4e, the code generated for the two signals in ObjectManager have the wrong direction. They should be "out" signals, but the generated code says they are "in" signals. This caused the service to not be displayed properly in d-feet. See discussion in #7 for further details.
As mentioned in #7, when this was discovered, even if one sets direction="out" in the xml specification, it still generates the code with direction "in".
The default direction for a signal should be always "out".
Hi Emanoil, during my lunch break I took a look at your PR. It works correctly but there are some unnecessary code changes.
I have prepared PR #22 partially based on your work: this also improves code related to signal emission, which is only called (and supposed to be called) for signals, no methods. Please review and let me know what you think.
Solved by PR #22.