Code generated for signals use wrong direction. #19

Zamknięty
otworzone 5 lat temu przez MicheleC · 3 komentarzy
MicheleC skomentował(-a) 5 lat temu
Właściciel

With reference to https://mirror.git.trinitydesktop.org/gitea/deloptes/dbus-1-tqt-example/src/branch/master/4e, the code generated for the two signals in ObjectManager have the wrong direction. They should be "out" signals, but the generated code says they are "in" signals. This caused the service to not be displayed properly in d-feet. See discussion in #7 for further details.

With reference to https://mirror.git.trinitydesktop.org/gitea/deloptes/dbus-1-tqt-example/src/branch/master/4e, the code generated for the two signals in ObjectManager have the wrong direction. They should be "out" signals, but the generated code says they are "in" signals. This caused the service to not be displayed properly in d-feet. See discussion in #7 for further details.
deloptes skomentował(-a) 5 lat temu
Współpracownik

As mentioned in #7, when this was discovered, even if one sets direction="out" in the xml specification, it still generates the code with direction "in".

The default direction for a signal should be always "out".

As mentioned in #7, when this was discovered, even if one sets direction="out" in the xml specification, it still generates the code with direction "in". The default direction for a signal should be always "out".
MicheleC dodaje to do kamienia milowego R14.1.0 release 5 lat temu
MicheleC skomentował(-a) 5 lat temu
Autor
Właściciel

Hi Emanoil, during my lunch break I took a look at your PR. It works correctly but there are some unnecessary code changes.

I have prepared PR #22 partially based on your work: this also improves code related to signal emission, which is only called (and supposed to be called) for signals, no methods. Please review and let me know what you think.

Hi Emanoil, during my lunch break I took a look at your PR. It works correctly but there are some unnecessary code changes.<br> I have prepared PR #22 partially based on your work: this also improves code related to signal emission, which is only called (and supposed to be called) for signals, no methods. Please review and let me know what you think.
MicheleC skomentował(-a) 5 lat temu
Autor
Właściciel

Solved by PR #22.

Solved by PR #22.
MicheleC zamknął(-ęła) to zgłoszenie 5 lat temu
Zaloguj się, aby dołączyć do tej rozmowy.
Brak kamienia milowego
Brak przypisanych
Uczestnicy 2
Powiadomienia
Termin realizacji

Brak ustawionego terminu realizacji.

Zależności

No dependencies set.

Reference: TDE/dbus-1-tqt#19
Ładowanie…
Nie ma jeszcze treści.