FTBFS for the app when there is unixfd in use #29

Signed-off-by: Emanoil Kotsev deloptes@gmail.com

It happened that I try to build code generated by org.ofono.HandsfreeAudioCard.xml, which uses FDs and it failed compiling with a message "dbus/dbus.h" not found.

Removing the line fixes the code. I do not even know why it should be there. It makes no sense. And probably it was overseen as the FD is very rearely used.

UnixFD is definitely used in TDE/tdepowersave. Therefore, I am surprised that it can cause FTBFS somewhere. So we have to test whether the patch does not cause FTBFS in tdepowersave 😉

Slavek, it is not about the unixfd, but about the #include dbus/dbus.h in tqdbusunixfd.h
I think you misunderstood my message.

Slavek, it is not about the unixfd, but about the #include dbus/dbus.h in tqdbusunixfd.h
I think you misunderstood my message.

Yes, I am interested in tqdbusunixfd.h, which is used in tdepowersave because there is used dbus type UnixFD. Therefore, I want to verify that the change in tqdbusunixfd.h will not have a side effect in tdepowersave.

Ok, I see it. Include dbus/dbus.h is here to allow verify that dBus already defines the type DBUS_TYPE_UNIX_FD and DBUS_TYPE_UNIX_FD_AS_STRING. In the case of an older version of dBus, there is a local definition to ensure forward compatibility.

In the case of the removal of the include, this causes the local definition to be used always, regardless of the fact that it can be conflicting with a definition in dBus. This does not look like the right solution. IMO, as a better solution, ${DBUS_INCLUDE_DIRS} should be added in your application to include_directories(...).

Slavek,
thank you for the analyses. You are 101% correct. It seems I have not added DBUS_INCLUDE_DIRS in the cmake configuration. Including it solved my issue.