TDE
/
dbus-1-tqt
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

Fix the missing code generation for Introspect interface, #31

Merged
SlavekB merged 1 commits from fix/generating-defined-introspectInterface into master 1 year ago
Conversation 2 Commits 1 Files Changed 1
SlavekB commented 1 year ago
Owner

if the interface is defined in the XML file.

If the Introspectable interface is not defined in the XML file, we generate it automatically. If the interface in the XML file is defined, we omit the code generation for this interface. This obviously doesn't make sense. This is probably the reason why the Introspectable interface in the XML files is commented in TDE/tdebluez.

if the interface is defined in the XML file. If the `Introspectable` interface is not defined in the XML file, we generate it automatically. If the interface in the XML file is defined, we omit the code generation for this interface. This obviously doesn't make sense. This is probably the reason why the `Introspectable` interface in the XML files is commented in [TDE/tdebluez](../tdebluez).
SlavekB added 1 commit 1 year ago
a6ebaff628
Fix the missing code generation for Introspect interface,
SlavekB added this to the R14.1.0 release milestone 1 year ago
deloptes commented 1 year ago
Collaborator

if the interface is defined in the XML file.

If the Introspectable interface is not defined in the XML file, we generate it automatically. If the interface in the XML file is defined, we omit the code generation for this interface. This obviously doesn't make sense. This is probably the reason why the Introspectable interface in the XML files is commented in TDE/tdebluez.

I think we were looking into it when fixing dbus-1-tqt, but couldn't make the decision what to do with that.
IMO it should always generate the code.

> if the interface is defined in the XML file. > > If the `Introspectable` interface is not defined in the XML file, we generate it automatically. If the interface in the XML file is defined, we omit the code generation for this interface. This obviously doesn't make sense. This is probably the reason why the `Introspectable` interface in the XML files is commented in [TDE/tdebluez](../tdebluez). I think we were looking into it when fixing dbus-1-tqt, but couldn't make the decision what to do with that. IMO it should always generate the code.
SlavekB commented 1 year ago
Poster
Owner

if the interface is defined in the XML file.

If the Introspectable interface is not defined in the XML file, we generate it automatically. If the interface in the XML file is defined, we omit the code generation for this interface. This obviously doesn't make sense. This is probably the reason why the Introspectable interface in the XML files is commented in TDE/tdebluez.

I think we were looking into it when fixing dbus-1-tqt, but couldn't make the decision what to do with that.
IMO it should always generate the code.

Yes, I also think that the intention is for Introspectable interface to be generated always – either because it is defined in the XML file or because we automatically add it. The current state simply makes no sense.

> > if the interface is defined in the XML file. > > > > If the `Introspectable` interface is not defined in the XML file, we generate it automatically. If the interface in the XML file is defined, we omit the code generation for this interface. This obviously doesn't make sense. This is probably the reason why the `Introspectable` interface in the XML files is commented in [TDE/tdebluez](../tdebluez). > > I think we were looking into it when fixing dbus-1-tqt, but couldn't make the decision what to do with that. > IMO it should always generate the code. Yes, I also think that the intention is for `Introspectable` interface to be generated always – either because it is defined in the XML file or because we automatically add it. The current state simply makes no sense.
MicheleC approved these changes 1 year ago
MicheleC left a comment
Owner

Looks good.

Looks good.
SlavekB force-pushed fix/generating-defined-introspectInterface from a6ebaff628 to fd60f35194 1 year ago
SlavekB merged commit fd60f35194 into master 1 year ago
SlavekB deleted branch fix/generating-defined-introspectInterface 1 year ago

Reviewers

MicheleC approved these changes 1 year ago
The pull request has been merged as fd60f35194.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MicheleC
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.0 release
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Blocks
#12 Allow to define an Introspectable interface in XML files.
TDE/tdebluez
Reference: TDE/dbus-1-tqt#31
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'fix/generating-defined-introspectInterface'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes