dbus-1-tqt does not support array of objectpathkeymaps #1

Birleştirildi
SlavekB 5 yıl önce bug/2925/objectpath içindeki 1 işlemeyi master ile birleştirdi
deloptes 6 yıl önce yorum yaptı
Katkıcı

https://bugs.trinitydesktop.org/show_bug.cgi?id=2925

When trying to parse data with signature a{oa{sa{sv}}} the flow is something like this:

TQT_DBusProxy::sendWithReply
-> TQT_DBusConnection::sendWithReply
-> TQT_DBusMessage::fromDBusMessage(reply)
-> TQT_DBusMarshall::messageToList(message, dmsg)
-> qFetchParameter(&it)
-> TQT_DBusData qFetchMap
-> qFetchStringKeyMapEntry

It turned out that it does not support array of objectpathkeymaps and it was returning a null key, which explains why it was returning always the last entry

https://bugs.trinitydesktop.org/show_bug.cgi?id=2925 When trying to parse data with signature a{oa{sa{sv}}} the flow is something like this: TQT_DBusProxy::sendWithReply -> TQT_DBusConnection::sendWithReply -> TQT_DBusMessage::fromDBusMessage(reply) -> TQT_DBusMarshall::messageToList(message, dmsg) -> qFetchParameter(&it) -> TQT_DBusData qFetchMap -> qFetchStringKeyMapEntry It turned out that it does not support array of objectpathkeymaps and it was returning a null key, which explains why it was returning always the last entry
SlavekB 5 yıl önce incelendi
SlavekB bir yorum yaptı
Sahibi

The code looks good. It does not seem to cause any change to the API / ABI. Please, just a little cleaning.

Note: Please remove the test output as an ammend of an existing commit and then use push with -f.

The code looks good. It does not seem to cause any change to the API / ABI. Please, just a little cleaning. Note: Please remove the test output as an ammend of an existing commit and then use push with -f.
// dbus_message_iter_get_fixed_array(&sub,&data,&len);
// return TQCString(data,len);
// } else {
SlavekB 5 yıl önce yorum yaptı
Sahibi

Well, it's a good idea to remove this unused code. It looks a little confusing, so it'll be better if it's gone.

Well, it's a good idea to remove this unused code. It looks a little confusing, so it'll be better if it's gone.
MicheleC 5 yıl önce yorum yaptı
Sahibi

Any idea why that code was commented out? Could it be useful?

Any idea why that code was commented out? Could it be useful?
SlavekB 5 yıl önce yorum yaptı
Sahibi

I have no idea. This code is here in a comment from the first commit into the Trinity repository. Additionally, obviously if / else / else is not consistent.

I have no idea. This code is here in a comment from the first commit into the Trinity repository. Additionally, obviously if / else / else is not consistent.
MicheleC 5 yıl önce yorum yaptı
Sahibi

yes, the commented else is obviously confusing. Given that the code was always commented out from the beginning, removing it seems ok 👍

yes, the commented else is obviously confusing. Given that the code was always commented out from the beginning, removing it seems ok :+1:
deloptes 5 yıl önce yorum yaptı
Poster
Katkıcı

This was the reason why I removed it - it seems it was never used or at least not in this life of this piece of software

This was the reason why I removed it - it seems it was never used or at least not in this life of this piece of software
Q_ASSERT(dbus_message_iter_has_next(&itemIter));
TQString key = qFetchParameter(&itemIter).toString();
// tqDebug("qFetchStringKeyMapEntry key : %s", key.latin1());
SlavekB 5 yıl önce yorum yaptı
Sahibi

Please, can you remove this unused test output from your patch?

Please, can you remove this unused test output from your patch?
SlavekB 5 yıl önce yorum yaptı
Sahibi

@deloptes, please do the small cleaning as mentioned in the review above.

@deloptes, please do the small cleaning as mentioned in the review above.
deloptes 5 yıl önce yorum yaptı
Poster
Katkıcı

Hi Slavek,
sorry for the multiple commits, I tried for first time the ammend but failed miserably :)

regards

Hi Slavek, sorry for the multiple commits, I tried for first time the ammend but failed miserably :) regards
SlavekB 5 yıl önce yorum yaptı
Sahibi

All right, it does not matter – I did squash to combine your series of commits into one 😸

All right, it does not matter – I did squash to combine your series of commits into one :smile_cat:
SlavekB 5 yıl önce değişiklik isteğini kapattı
SlavekB bug/2925/objectpath dalı silindi 5 yıl önce
SlavekB 5 yıl önce R14.0.6 release kilometre taşına ekledi
Değişiklik isteği f126c44916 olarak birleştirildi.
Bu konuşmaya katılmak için oturum aç.
Değerlendirici yok
Kilometre Taşı Yok
Atanan Kişi Yok
3 Katılımcı
Bildirimler
Bitiş Tarihi

Bitiş tarihi atanmadı.

Bağımlılıklar

Bağımlılık yok.

Referans: TDE/dbus-1-tqt#1
Yükleniyor…
Henüz bir içerik yok.