dbus-1-tqt does not support array of objectpathkeymaps #1

Злито
SlavekB злито 1 комітів з bug/2925/objectpath до master 5 роки тому
deloptes прокоментував(ла) 6 роки тому
Співавтор

https://bugs.trinitydesktop.org/show_bug.cgi?id=2925

When trying to parse data with signature a{oa{sa{sv}}} the flow is something like this:

TQT_DBusProxy::sendWithReply
-> TQT_DBusConnection::sendWithReply
-> TQT_DBusMessage::fromDBusMessage(reply)
-> TQT_DBusMarshall::messageToList(message, dmsg)
-> qFetchParameter(&it)
-> TQT_DBusData qFetchMap
-> qFetchStringKeyMapEntry

It turned out that it does not support array of objectpathkeymaps and it was returning a null key, which explains why it was returning always the last entry

https://bugs.trinitydesktop.org/show_bug.cgi?id=2925 When trying to parse data with signature a{oa{sa{sv}}} the flow is something like this: TQT_DBusProxy::sendWithReply -> TQT_DBusConnection::sendWithReply -> TQT_DBusMessage::fromDBusMessage(reply) -> TQT_DBusMarshall::messageToList(message, dmsg) -> qFetchParameter(&it) -> TQT_DBusData qFetchMap -> qFetchStringKeyMapEntry It turned out that it does not support array of objectpathkeymaps and it was returning a null key, which explains why it was returning always the last entry
SlavekB рецензовано 5 роки тому
SlavekB додав коментар
Власник

The code looks good. It does not seem to cause any change to the API / ABI. Please, just a little cleaning.

Note: Please remove the test output as an ammend of an existing commit and then use push with -f.

The code looks good. It does not seem to cause any change to the API / ABI. Please, just a little cleaning. Note: Please remove the test output as an ammend of an existing commit and then use push with -f.
// dbus_message_iter_get_fixed_array(&sub,&data,&len);
// return TQCString(data,len);
// } else {
SlavekB прокоментував(ла) 5 роки тому
Власник

Well, it's a good idea to remove this unused code. It looks a little confusing, so it'll be better if it's gone.

Well, it's a good idea to remove this unused code. It looks a little confusing, so it'll be better if it's gone.
MicheleC прокоментував(ла) 5 роки тому
Власник

Any idea why that code was commented out? Could it be useful?

Any idea why that code was commented out? Could it be useful?
SlavekB прокоментував(ла) 5 роки тому
Власник

I have no idea. This code is here in a comment from the first commit into the Trinity repository. Additionally, obviously if / else / else is not consistent.

I have no idea. This code is here in a comment from the first commit into the Trinity repository. Additionally, obviously if / else / else is not consistent.
MicheleC прокоментував(ла) 5 роки тому
Власник

yes, the commented else is obviously confusing. Given that the code was always commented out from the beginning, removing it seems ok 👍

yes, the commented else is obviously confusing. Given that the code was always commented out from the beginning, removing it seems ok :+1:
deloptes прокоментував(ла) 5 роки тому
Автор
Співавтор

This was the reason why I removed it - it seems it was never used or at least not in this life of this piece of software

This was the reason why I removed it - it seems it was never used or at least not in this life of this piece of software
tqdbusmarshall.cpp Застарілі
Q_ASSERT(dbus_message_iter_has_next(&itemIter));
TQString key = qFetchParameter(&itemIter).toString();
// tqDebug("qFetchStringKeyMapEntry key : %s", key.latin1());
SlavekB прокоментував(ла) 5 роки тому
Власник

Please, can you remove this unused test output from your patch?

Please, can you remove this unused test output from your patch?
SlavekB прокоментував(ла) 5 роки тому
Власник

@deloptes, please do the small cleaning as mentioned in the review above.

@deloptes, please do the small cleaning as mentioned in the review above.
deloptes прокоментував(ла) 5 роки тому
Автор
Співавтор

Hi Slavek,
sorry for the multiple commits, I tried for first time the ammend but failed miserably :)

regards

Hi Slavek, sorry for the multiple commits, I tried for first time the ammend but failed miserably :) regards
SlavekB прокоментував(ла) 5 роки тому
Власник

All right, it does not matter – I did squash to combine your series of commits into one 😸

All right, it does not matter – I did squash to combine your series of commits into one :smile_cat:
SlavekB закрив цей запит на злиття 5 роки тому
SlavekB видалена гілка bug/2925/objectpath 5 роки тому
SlavekB додав(ла) до R14.0.6 release етапу 5 роки тому
Запит на злиття був влитиий як f126c44916.
Підпишіться щоб приєднатися до обговорення.
Немає рецензентів
Етап відсутній
Немає виконавця
3 учасників
Сповіщення
Дата завершення

Термін виконання не встановлений.

Залежності

No dependencies set.

Reference: TDE/dbus-1-tqt#1
Завантаження…
Тут ще немає жодного змісту.