dbus-1-tqt does not support array of objectpathkeymaps #1

已合併
SlavekB 5 年之前 將 1 次代碼提交從 bug/2925/objectpath 合併至 master
協同者

https://bugs.trinitydesktop.org/show_bug.cgi?id=2925

When trying to parse data with signature a{oa{sa{sv}}} the flow is something like this:

TQT_DBusProxy::sendWithReply
-> TQT_DBusConnection::sendWithReply
-> TQT_DBusMessage::fromDBusMessage(reply)
-> TQT_DBusMarshall::messageToList(message, dmsg)
-> qFetchParameter(&it)
-> TQT_DBusData qFetchMap
-> qFetchStringKeyMapEntry

It turned out that it does not support array of objectpathkeymaps and it was returning a null key, which explains why it was returning always the last entry

https://bugs.trinitydesktop.org/show_bug.cgi?id=2925 When trying to parse data with signature a{oa{sa{sv}}} the flow is something like this: TQT_DBusProxy::sendWithReply -> TQT_DBusConnection::sendWithReply -> TQT_DBusMessage::fromDBusMessage(reply) -> TQT_DBusMarshall::messageToList(message, dmsg) -> qFetchParameter(&it) -> TQT_DBusData qFetchMap -> qFetchStringKeyMapEntry It turned out that it does not support array of objectpathkeymaps and it was returning a null key, which explains why it was returning always the last entry
SlavekB reviewed 5 年之前
SlavekB left a comment
所有者

The code looks good. It does not seem to cause any change to the API / ABI. Please, just a little cleaning.

Note: Please remove the test output as an ammend of an existing commit and then use push with -f.

The code looks good. It does not seem to cause any change to the API / ABI. Please, just a little cleaning. Note: Please remove the test output as an ammend of an existing commit and then use push with -f.
// dbus_message_iter_get_fixed_array(&sub,&data,&len);
// return TQCString(data,len);
// } else {
所有者

Well, it's a good idea to remove this unused code. It looks a little confusing, so it'll be better if it's gone.

Well, it's a good idea to remove this unused code. It looks a little confusing, so it'll be better if it's gone.
所有者

Any idea why that code was commented out? Could it be useful?

Any idea why that code was commented out? Could it be useful?
所有者

I have no idea. This code is here in a comment from the first commit into the Trinity repository. Additionally, obviously if / else / else is not consistent.

I have no idea. This code is here in a comment from the first commit into the Trinity repository. Additionally, obviously if / else / else is not consistent.
所有者

yes, the commented else is obviously confusing. Given that the code was always commented out from the beginning, removing it seems ok 👍

yes, the commented else is obviously confusing. Given that the code was always commented out from the beginning, removing it seems ok :+1:
發佈者
協同者

This was the reason why I removed it - it seems it was never used or at least not in this life of this piece of software

This was the reason why I removed it - it seems it was never used or at least not in this life of this piece of software
Q_ASSERT(dbus_message_iter_has_next(&itemIter));
TQString key = qFetchParameter(&itemIter).toString();
// tqDebug("qFetchStringKeyMapEntry key : %s", key.latin1());
所有者

Please, can you remove this unused test output from your patch?

Please, can you remove this unused test output from your patch?
所有者

@deloptes, please do the small cleaning as mentioned in the review above.

@deloptes, please do the small cleaning as mentioned in the review above.
發佈者
協同者

Hi Slavek,
sorry for the multiple commits, I tried for first time the ammend but failed miserably :)

regards

Hi Slavek, sorry for the multiple commits, I tried for first time the ammend but failed miserably :) regards
所有者

All right, it does not matter – I did squash to combine your series of commits into one 😸

All right, it does not matter – I did squash to combine your series of commits into one :smile_cat:
SlavekB closed this pull request 5 年之前
SlavekB 刪除分支 bug/2925/objectpath 5 年之前
SlavekB 新增至R14.0.6 release 里程碑 5 年之前
The pull request has been merged as f126c44916.
登入 才能加入這對話。
No reviewers
未選擇里程碑
No Assignees
3 參與者
訊息
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/dbus-1-tqt#1
Loading…
尚未有任何內容