TDE
/
dbus-1-tqt
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

Fix GCC visibility, use common tests in CMake rules #4

Merged
SlavekB merged 1 commits from feat/cmakeCommonTests into master 5 years ago
Conversation 0 Commits 1 Files Changed 2
SlavekB commented 5 years ago
Owner

DBus-1-tqt seems to be well prepared to build with gcc visibility. Export missed only on a few new classes. However, please test it before we merge it.

Note: For test you need to build with WITH_ALL_OPTIONS or WITH_GCC_VISIBILITY.

DBus-1-tqt seems to be well prepared to build with gcc visibility. Export missed only on a few new classes. However, please test it before we merge it. Note: For test you need to build with WITH_ALL_OPTIONS or WITH_GCC_VISIBILITY.
SlavekB added the PR/rfc label 5 years ago
MicheleC approved these changes 5 years ago
MicheleC left a comment
Owner

Seems ok at first sight.

Seems ok at first sight.
SlavekB removed the PR/rfc label 5 years ago
SlavekB closed this pull request 5 years ago
SlavekB deleted branch feat/cmakeCommonTests 5 years ago
SlavekB added this to the R14.0.6 release milestone 5 years ago
The pull request has been merged as c60f02f5be.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.6 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/dbus-1-tqt#4
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/cmakeCommonTests'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes