TDE
/
desktop-effects-tde
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

Conversion to CMake build system. #3

Merged
SlavekB merged 1 commits from feat/cmake-conv into master 1 year ago
Conversation 0 Commits 1 Files Changed 10
SlavekB commented 1 year ago
Owner

Copy translations to a new directory layout.
Added translation of .desktop files.

It turned out that setup.py does not perform anything but copying files to the desired locations. At the same time, this means that admin module is unnecessary here. Therefore, there is nothing special that would prevent the conversion to CMake.

Because the original rules did not install translations at all, I made a copy of translations to the new layout. Because the original desktop file did not contain any translations, I did the preparation for its translation.

Copy translations to a new directory layout. Added translation of .desktop files. It turned out that `setup.py` does not perform anything but copying files to the desired locations. At the same time, this means that `admin` module is unnecessary here. Therefore, there is nothing special that would prevent the conversion to CMake. Because the original rules did not install translations at all, I made a copy of translations to the new layout. Because the original desktop file did not contain any translations, I did the preparation for its translation.
SlavekB added this to the R14.1.0 release milestone 1 year ago
SlavekB added 1 commit 1 year ago
a628345357
Conversion to CMake build system.
MicheleC approved these changes 1 year ago
MicheleC left a comment
Owner

Looks good

Looks good
SlavekB merged commit a628345357 into master 1 year ago
SlavekB deleted branch feat/cmake-conv 1 year ago

Reviewers

MicheleC approved these changes 1 year ago
The pull request has been merged as a628345357.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MicheleC
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.0 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Blocks
#173 DEB desktop-effects-tde: Switch to CMake build system.
TDE/tde-packaging
Reference: TDE/desktop-effects-tde#3
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/cmake-conv'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes