TDE
/
dolphin
6
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
Labels Milestones
New Issue

cmake conversion isn't complete #2

Closed
opened 5 years ago by Ghost · 3 comments
Ghost commented 5 years ago

This ticket acts as a reminder.

Doc and Po folders aren't processed yet.
Can add a man page from Debian.
The triumvirate (CMakeLists.txt, config.h.cmake, ConfigureChecks.cmake) need some care.

This ticket acts as a reminder. Doc and Po folders aren't processed yet. Can add a man page from Debian. The triumvirate (CMakeLists.txt, config.h.cmake, ConfigureChecks.cmake) need some care.
SlavekB commented 5 years ago
Owner

How about CMakeLists.txt + ConfigureChecks.cmake + config.h.cmake?

How about CMakeLists.txt + ConfigureChecks.cmake + config.h.cmake?
Ghost commented 5 years ago
Poster

Please keep the ticket open for a while, confih.h.cmake is empty, WITH_LIBVISUAL in CMakeList.txt...I need time to review dolphin's files in order to find out what's going on.
I'll probably do It today or tomorrow.

Please keep the ticket open for a while, confih.h.cmake is empty, WITH_LIBVISUAL in CMakeList.txt...I need time to review dolphin's files in order to find out what's going on. I'll probably do It today or tomorrow.
SlavekB commented 5 years ago
Owner

Fixed by above mentioned commits.

Fixed by above mentioned commits.
SlavekB closed this issue 5 years ago
SlavekB added this to the R14.0.6 release milestone 5 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
r14.1.x
r14.0.x
v3.5.13-sru
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.6 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/dolphin#2
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes