#5 this (hopefully) complete issue 2

Merged
SlavekB merged 1 commits from issue/2 into master 3 months ago
cethyel commented 3 months ago

I didn’t see the need for the libvisual stuff, so I got rid of It.
config.h.cmake has been written as the usual…

I didn't see the need for the libvisual stuff, so I got rid of It. config.h.cmake has been written as the usual...
SlavekB reviewed 3 months ago
It looks good. Just a supplementary question – see below.
@@ -42,4 +43,1 @@
42 43
 
43
-##### optional stuff ############################
44
-
45
-# option( WITH_LIBVISUAL "Enable libvisual support" OFF )
SlavekB

Were you considering using the usual options WITH_ALL_OPTIONS and WITH_GCC_VISIBILITY here?

Were you considering using the usual options WITH_ALL_OPTIONS and WITH_GCC_VISIBILITY here?
SlavekB approved these changes 3 months ago
It looks good.
SlavekB deleted branch issue/2 3 months ago
SlavekB added this to the R14.0.6 release milestone 3 months ago

Reviewers

SlavekB approved these changes 3 months ago
The pull request has been merged.
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.