this (hopefully) complete issue 2 #5

Обединени

SlavekB обедини 1 ревизии от issue/2 във master

Ghost коментира

I didn't see the need for the libvisual stuff, so I got rid of It.
config.h.cmake has been written as the usual...

SlavekB reviewed

SlavekB left a comment

Притежател

It looks good. Just a supplementary question – see below.

CMakeLists.txt

													
					##### optional stuff ############################

					# option( WITH_LIBVISUAL "Enable libvisual support" OFF )

SlavekB коментира

Притежател

Were you considering using the usual options WITH_ALL_OPTIONS and WITH_GCC_VISIBILITY here?

SlavekB approved these changes

SlavekB left a comment

Притежател

It looks good.

SlavekB closed this pull request

SlavekB deleted branch issue/2

SlavekB added this to the R14.0.6 release milestone

Тази заявка за сливане е била обединена като 7c4e6cb681.

Впишете се за да се присъедините към разговора.

No reviewers

Няма изпълнители

2 участника

Известия

Due Date

No due date set.

Зависимости

No dependencies set.

Reference: TDE/dolphin#5