TDE
/
dolphin
6
0
複製 0
程式碼 問題管理 2 合併請求 版本發佈 Wiki Activity
標籤 里程碑

this (hopefully) complete issue 2 #5

已合併
SlavekB 於 5 年之前 將 1 次代碼提交從 issue/2 合併至 master
對話內容 0 程式碼提交 1 Files Changed 2
Ghost 評論 5 年之前

I didn't see the need for the libvisual stuff, so I got rid of It.
config.h.cmake has been written as the usual...

I didn't see the need for the libvisual stuff, so I got rid of It. config.h.cmake has been written as the usual...
SlavekB reviewed 5 年之前
SlavekB left a comment
所有者

It looks good. Just a supplementary question – see below.

It looks good. Just a supplementary question – see below.
CMakeLists.txt
##### optional stuff ############################
# option( WITH_LIBVISUAL "Enable libvisual support" OFF )
SlavekB 評論 5 年之前
所有者

Were you considering using the usual options WITH_ALL_OPTIONS and WITH_GCC_VISIBILITY here?

Were you considering using the usual options WITH_ALL_OPTIONS and WITH_GCC_VISIBILITY here?
SlavekB approved these changes 5 年之前
SlavekB left a comment
所有者

It looks good.

It looks good.
SlavekB closed this pull request 5 年之前
SlavekB 刪除分支 issue/2 5 年之前
SlavekB 新增至R14.0.6 release 里程碑 5 年之前
The pull request has been merged as 7c4e6cb681.
登入 才能加入這對話。
Reviewers
Request review
No reviewers
標籤
Apply labels
清除已選取標籤
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
未選擇標籤 GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
里程碑
Set milestone
清除已選取里程碑
No items
未選擇里程碑
R14.0.6 release
Assignees
Assign users
Clear assignees
No Assignees
2 參與者
訊息
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/dolphin#5
Write Preview
Loading…
取消
儲存
尚未有任何內容
Delete Branch 'issue/2'

Deleting a branch is permanent. It CANNOT be undone. Continue?

取消操作
確認操作