Refresh directory without requiring a re-scan after delete #4

Open
opened 1 year ago by InvertedRabbit · 3 comments
Collaborator

Basic information

  • TDE version: R14.0.13
  • App version: git-339cd31bd6
  • Distribution: Artix Linux 6.0.5-zen1-1-zen (Arch)
  • Hardware: x86_64, armv7h

Description

Deleting a file/folder in a currently scanned directory will gray out the scan, disabling interactions which requires another scan to fix. Filelight should instead remove the successfully deleted file in question from view instead of requiring a new scan to update, without disabling interactions within the view.

I've attached a video recording of the issue below. You can see that tooltips no longer show up after deleting a file. It may not be clear, but I do right-click too with no avail.

Steps to reproduce

  1. Scan a folder, any folder.
  2. Delete any file/folder in your view.
  3. All files in view will gray out, tooltips do not appear, and clicking them does nothing.

Screenshots

<!-- This is a comment. Please fill in the required fields below. The comments provide instructions on how to do so. Note: You do not need to remove comments. --> ## Basic information - TDE version: R14.0.13 - App version: git-339cd31bd6 - Distribution: Artix Linux 6.0.5-zen1-1-zen (Arch) - Hardware: x86_64, armv7h <!-- Use SL/* labels to set the severity level. Please do not set a milestone. --> ## Description Deleting a file/folder in a currently scanned directory will gray out the scan, disabling interactions which requires another scan to fix. Filelight should instead remove the successfully deleted file in question from view instead of requiring a new scan to update, without disabling interactions within the view. I've attached a video recording of the issue below. You can see that tooltips no longer show up after deleting a file. It may not be clear, but I do right-click too with no avail. ## Steps to reproduce 1. Scan a folder, any folder. 2. Delete any file/folder in your view. 3. All files in view will gray out, tooltips do not appear, and clicking them does nothing. ## Screenshots <!-- If it seems useful, please provide provide one or more screenshots. -->
Owner

This is a good idea, although may be not as simple as simply deleting the entity from the graph. It will be important to make sure of what files are deleted and what not and update the graph accordingly

This is a good idea, although may be not as simple as simply deleting the entity from the graph. It will be important to make sure of what files are deleted and what not and update the graph accordingly
Poster
Collaborator

How does modern Filelight do it? Might be worth investigating that to see if we can recreate the method.

How does modern Filelight do it? Might be worth investigating that to see if we can recreate the method.
Owner

Not sure about what "modern" filelight does, but I guess checking its behavior and looking at backporting some of the code does not hurt :-)
If you can have a look and report on its behavior, we can then decide whether to backport some code or not.

Not sure about what "modern" filelight does, but I guess checking its behavior and looking at backporting some of the code does not hurt :-) If you can have a look and report on its behavior, we can then decide whether to backport some code or not.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/filelight#4
Loading…
There is no content yet.