#1 cmake conversion

Merged
SlavekB merged 5 commits from feat/cmakeConv into master 9 months ago
cethyel commented 9 months ago

Don’t feel at ease with this one.
I couldn’t build It with automake, so this is built with cmake right from the get-go.
The heimdal package (which is needed for libtdeldap) provided by slackbuilds locked me out of my root account through the ‘su’ command till I figured out what was going on.
The ‘doc’ folder is actually empty.
There is no *.po files in the ‘po’ folder, I’ve added a CMakeLists.txt nonetheless.
Waiting for your comments Slavek.

I’ll change ‘requested’ to ‘required’ after your comments.

Don't feel at ease with this one. I couldn't build It with automake, so this is built with cmake right from the get-go. The heimdal package (which is needed for libtdeldap) provided by slackbuilds locked me out of my root account through the 'su' command till I figured out what was going on. The 'doc' folder is actually empty. There is no *.po files in the 'po' folder, I've added a CMakeLists.txt nonetheless. Waiting for your comments Slavek. I'll change 'requested' to 'required' after your comments.
cethyel added the
PR/rfc
label 9 months ago
SlavekB commented 9 months ago
Owner

Yes, right, requested => required would have my comment :smile_cat: However, because I encountered some other problems, I solved it in a subsequent patch:

  1. On Debian, some include are still in the subdirectory ${TDE_INCLUDE_DIR}/tde.

  2. Include files for kerberos may be in a special directory – for example, to allow both MIT and Heimdal to be installed concurrently. So I added the KRB5 library detection and ${KRB5_INCLUDE_DIRS}.

  3. Traditional problem with includes in UI files.

  4. Occasional problem with improper automoc.

  5. Unexpectedly different solution for TQT_NO_ASCII_CAST.

In any case, your base was good.

Yes, right, requested => required would have my comment :smile_cat: However, because I encountered some other problems, I solved it in a subsequent patch: 1. On Debian, some include are still in the subdirectory ${TDE_INCLUDE_DIR}/tde. 2. Include files for kerberos may be in a special directory – for example, to allow both MIT and Heimdal to be installed concurrently. So I added the KRB5 library detection and ${KRB5_INCLUDE_DIRS}. 3. Traditional problem with includes in UI files. 4. Occasional problem with improper automoc. 5. Unexpectedly different solution for TQT_NO_ASCII_CAST. In any case, your base was good.
SlavekB removed the
PR/rfc
label 9 months ago
SlavekB deleted branch feat/cmakeConv 9 months ago
SlavekB added this to the R14.0.6 release milestone 9 months ago
The pull request has been merged.
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.