cmake conversion #1
Fusionnée
SlavekB
a fusionné 1 révision(s) à partir de feat/cmakeConv
vers master
il y a 6 ans
Chargement…
Référencer dans un nouveau ticket
Il n'existe pas encore de contenu.
Supprimer la branche 'feat/cmakeConv'
Supprimer une branche est permanent. Cela NE PEUVENT être annulées. Continuer ?
Tell me what you think...
Cheers.
@+
Hi Greg,
I just tried a build in buster of the cmake version.
As is, it won't build. It will fail with a
error message.
I have not investigated further, will leave that to you and Slavek, while I prefer to work on other things.
I will be happy to test further if required.
If anything is required on the tde-packaging side, please create a PR also on that repository with reference to this PR.
@MicheleC this result is as expected because it is necessary to modify the files for Debian packaging. I'm already working on it. That's why I assigned this PR to myself :)
Hello my good man :-)
Here is how to test things on Slackware:
git clone gitea@mirror.git.trinitydesktop.org:TDE/kcpuload.git
cd kcpuload
git checkout feat/cmakeConv
git clone gitea@mirror.git.trinitydesktop.org:TDE/tde-common-cmake.git
cp -R tde-common-cmake/* cmake/
mkdir -p build && cd build
cmake ../ && make
Gosh! Didn't have the time to finish this, slavek is already on It!
I've done one small patch about installing the icons used inside the application - see commit
16a6ddcdd4
. Otherwise your patch looks fine and I do not see any obstacle to merging.Note: You can use a simpler procedure to get submodules:
I didn't build It yet, but from what I see, you must have followed the same path that the autotools do.
I've had this question since yesterday, so I'll ask.
What about xdg compliance?
Shouldn't all the icons go into /usr/share/icons ?
I've planed to add a man page for kcpuload (retrieved from an ubuntu source package).
What cmake command should I use?
At the moment, I've tested It like this:
INSTALL(
FILES ${PROJECT_NAME}.1
DESTINATION ${CMAKE_INSTALL_PREFIX}/man/man1
)
About comment 212: These are icons for application-specific actions. Therefore, I consider the location in ${PREFIX}/share/apps/<application>/icons to be reasonable.
About comment 213: Yes, it looks right. Only minor edits - here it is more appropriate to use a variable for installing man pages:
Gotcha!
I'm off for today...I'll submit tomorrow for the man page.
Maybe, I should wait for you to merge and then submit a new PR.
I'll probably add the page in kcpuload/doc/man
See you, but later!
Merged and pushed upstream.
Sorry guys, went to bed and couldn't follow up yesterday :-)
I suggest all cmake conversions to go only to R14.1 series, no R14.0.
cmake conversions are not minor changes IMO and should not be part of a maintenance release.
What do you think?
Discussed with Slavek. Ok to add to R14.0.x series 😄
16a6ddcdd4
.