TDE
/
kdiff3
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

Use common rules for build and install documentation and translations #3

Merged
SlavekB merged 1 commits from feat/use-common-tde-add-project-macros into master 3 years ago
Conversation 4 Commits 1 Files Changed 26
SlavekB commented 3 years ago
Owner

The project originally allowed to build completely separately - without KDE/TDE. For this reason, it contained a copy of the common documentation directory – en/common. When using common TDE rules for build and installing documentation, this causes unwanted installation of this directory.

We have two options:

  1. Move the directory outside en to not be installed.
    In the patch is moved to the other directory.
  2. Remove the directory.

What is your opinion?

The project originally allowed to build completely separately - without KDE/TDE. For this reason, it contained a copy of the common documentation directory – `en/common`. When using common TDE rules for build and installing documentation, this causes unwanted installation of this directory. We have two options: 1. Move the directory outside `en` to not be installed.<br/>In the patch is moved to the `other` directory. 2. Remove the directory. What is your opinion?
SlavekB added the PR/rfc label 3 years ago
SlavekB added 1 commit 3 years ago
MicheleC commented 3 years ago
Owner

Is there a valid reason to keep a copy of the original common documentation in another folder? If not, we may be better off by simply removing the folder in full.

Is there a valid reason to keep a copy of the original common documentation in another folder? If not, we may be better off by simply removing the folder in full.
SlavekB commented 3 years ago
Poster
Owner

We provide a version for TDE and there was no idea to provide a separate version independent of TDE or version for other operating systems. So there should be no reason to leave a copy of en/common directory.

We provide a version for TDE and there was no idea to provide a separate version independent of TDE or version for other operating systems. So there should be no reason to leave a copy of `en/common` directory.
MicheleC commented 3 years ago
Owner

Exactly. So let's simply remove the folder 😄

Exactly. So let's simply remove the folder :smile:
SlavekB force-pushed feat/use-common-tde-add-project-macros from 9805302c7f to 8cf09c0b46 3 years ago
SlavekB force-pushed feat/use-common-tde-add-project-macros from 8cf09c0b46 to 8392334986 3 years ago
SlavekB commented 3 years ago
Poster
Owner

Edited as discussed.

Edited as discussed.
MicheleC approved these changes 3 years ago
MicheleC left a comment
Owner

Looks good.

Looks good.
SlavekB merged commit 8392334986 into master 3 years ago
SlavekB deleted branch feat/use-common-tde-add-project-macros 3 years ago
SlavekB removed the PR/rfc label 3 years ago
SlavekB added this to the R14.0.11 release milestone 3 years ago

Reviewers

MicheleC approved these changes 3 years ago
The pull request has been merged as 8392334986.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MicheleC
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.11 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/kdiff3#3
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/use-common-tde-add-project-macros'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes