Add missing return in nonvoid functions #2

Merged
SlavekB merged 1 commits from ftbfs/no_return_in_nonvoid_functions into master 5 months ago
Collaborator

The Open Build Service linter complains about missing returns in non-void functions.
This patch add the returns.

The Open Build Service linter complains about missing returns in non-void functions. This patch add the returns.
Francois added 1 commit 5 months ago
Francois force-pushed ftbfs/no_return_in_nonvoid_functions from edec0c9030 to 5ba534b872 5 months ago
SlavekB requested changes 5 months ago
SlavekB left a comment

One occurrence seems incorrect. Please check it.

gtk2/kgtk2.c Outdated
realFunction(chooser);
if (((kgtkApp == APP_UNKNOWN) && BLACKLIST_UNKNOWN_GTK_APPS) || (kgtkApp == APP_BLACKLISTED) && realFunction) {
return;
return FALSE;
Poster
Owner

The return value of this function is void – here probably return FALSE is not in place.

The return value of this function is `void` – here probably `return FALSE` is not in place.
Poster
Collaborator

You are correct, I've removed this occurence and the linter is still happy.

You are correct, I've removed this occurence and the linter is still happy.
SlavekB marked this conversation as resolved
Francois force-pushed ftbfs/no_return_in_nonvoid_functions from 5ba534b872 to 98a4338d07 5 months ago
SlavekB approved these changes 5 months ago
SlavekB left a comment

It seems good.

SlavekB merged commit 98a4338d07 into master 5 months ago
SlavekB deleted branch ftbfs/no_return_in_nonvoid_functions 5 months ago
SlavekB added this to the R14.0.11 release milestone 5 months ago

Reviewers

SlavekB approved these changes 5 months ago
The pull request has been merged as 98a4338d07.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.