Insert an explicit cast for -Wc++11-narrowing error #5

Merged
MicheleC merged 1 commits from fix/add_static_cast into master 1 year ago
Ray-V commented 1 year ago
Collaborator

Patch for issue #4 as proposed by the error message.

Patch for issue #4 as proposed by the error message.
Ray-V added 1 commit 1 year ago
000c21b25c
Insert an explicit cast for -Wc++11-narrowing error
MicheleC approved these changes 1 year ago
MicheleC left a comment
Owner

Looks good, thanks a lot

Looks good, thanks a lot
MicheleC added this to the R14.1.0 release milestone 1 year ago
MicheleC requested changes 1 year ago
MicheleC left a comment
Owner

Could you actually review the commit message and add that "it resolves issue #4"? That will help for documentation on commit page.

Could you actually review the commit message and add that "it resolves issue #4"? That will help for documentation on commit page.
Ray-V force-pushed fix/add_static_cast from 000c21b25c to 76c89b83c5 1 year ago
SlavekB approved these changes 1 year ago
SlavekB left a comment
Owner

I did a test also on FreeBSD and the build was successful.

I did a test also on FreeBSD and the build was successful.
MicheleC approved these changes 1 year ago
MicheleC merged commit 76c89b83c5 into master 1 year ago
MicheleC deleted branch fix/add_static_cast 1 year ago
Owner

Thanks @Ray-V!

Thanks @Ray-V!
obache commented 1 year ago
Collaborator

Any reason to use such implementation depended internal type name __time_t and __suseconds_t?
They are not defined here, and why not using time_t and susecnds_t instead?

Any reason to use such implementation depended internal type name `__time_t` and `__suseconds_t`? They are not defined here, and why not using `time_t` and `susecnds_t` instead?
SlavekB commented 1 year ago
Owner

Any reason to use such implementation depended internal type name __time_t and __suseconds_t?
They are not defined here, and why not using time_t and susecnds_t instead?

That seems like a very good point. Kind of sad that it was a little later than the merge was done. In fact, I was hoping that a test on FreeBSD would show whether it would be better to use some portable defined type like you mention…

> Any reason to use such implementation depended internal type name `__time_t` and `__suseconds_t`? > They are not defined here, and why not using `time_t` and `susecnds_t` instead? That seems like a very good point. Kind of sad that it was a little later than the merge was done. In fact, I was hoping that a test on FreeBSD would show whether it would be better to use some portable defined type like you mention…
Owner

@Ray-V @obache
I updated the code as per comments above.
Could you please both check that PR #6 works fine on your systems?

tdelibs fix will follow once PR #6 has been tested.

@Ray-V @obache I updated the code as per comments above. Could you please both check that PR #6 works fine on your systems? tdelibs fix will follow once PR #6 has been tested.

Reviewers

SlavekB approved these changes 1 year ago
MicheleC approved these changes 1 year ago
The pull request has been merged as 76c89b83c5.
Sign in to join this conversation.
No Milestone
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/kile#5
Loading…
There is no content yet.