Insert an explicit cast for -Wc++11-narrowing error #5
Merged
MicheleC
merged 1 commits from fix/add_static_cast
into master
1 year ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'fix/add_static_cast'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Patch for issue #4 as proposed by the error message.
Looks good, thanks a lot
Could you actually review the commit message and add that "it resolves issue #4"? That will help for documentation on commit page.
000c21b25c
to76c89b83c5
1 year agoI did a test also on FreeBSD and the build was successful.
76c89b83c5
into master 1 year agoThanks @Ray-V!
Any reason to use such implementation depended internal type name
__time_t
and__suseconds_t
?They are not defined here, and why not using
time_t
andsusecnds_t
instead?That seems like a very good point. Kind of sad that it was a little later than the merge was done. In fact, I was hoping that a test on FreeBSD would show whether it would be better to use some portable defined type like you mention…
@Ray-V @obache
I updated the code as per comments above.
Could you please both check that PR #6 works fine on your systems?
tdelibs fix will follow once PR #6 has been tested.
Reviewers
76c89b83c5
.