TDE
/
kile
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

Improve code of commit 76c89b8. #6

Merged
MicheleC merged 1 commits from fix/pr5-conversion into master 1 year ago
Conversation 4 Commits 1 Files Changed 1
MicheleC commented 1 year ago
Owner

Improve code of PR #5 (see comments there)

Improve code of PR #5 (see comments there)
MicheleC added this to the R14.1.0 release milestone 1 year ago
MicheleC added 1 commit 1 year ago
f8453ccf3e
Improve code of commit 76c89b8.
MicheleC requested review from SlavekB 1 year ago
Ray-V commented 1 year ago
Collaborator

Tested for 32/64 bit, clang/gcc builds and all ok.

Tested for 32/64 bit, clang/gcc builds and all ok.
SlavekB approved these changes 1 year ago
SlavekB left a comment
Owner

Tested on FreeBSD – build successfull.

Tested on FreeBSD – build successfull.
MicheleC commented 1 year ago
Poster
Owner

Let's wait for @obache to test on his system too, before merging.

Let's wait for @obache to test on his system too, before merging.
obache commented 1 year ago
Collaborator

I cannot test for a long while, but this changes should be better than before.
Go ahead please.

I cannot test for a long while, but this changes should be better than before. Go ahead please.
MicheleC merged commit f8453ccf3e into master 1 year ago
MicheleC deleted branch fix/pr5-conversion 1 year ago
MicheleC commented 1 year ago
Poster
Owner

Thanks all for testing or commenting. Merged as discusses above (tdelibs patch will follow soon).
@obache if you still have problem when you test, please reopen this.

Thanks all for testing or commenting. Merged as discusses above (tdelibs patch will follow soon). @obache if you still have problem when you test, please reopen this.

Reviewers

SlavekB approved these changes 1 year ago
The pull request has been merged as f8453ccf3e.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.0 release
Assignees
Assign users
Clear assignees
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/kile#6
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'fix/pr5-conversion'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes