6
0
Fork 0

cmake conversion #1

Zusammengeführt
SlavekB hat 1 Commits von feat/cmakeConv nach master vor 6 Jahren zusammengeführt
Ghost hat vor 6 Jahren kommentiert

I've set the install of the Russian keyboard as default since I believe those speakers are the main users in this apps.

I didn't define USE_BOLD_MENUITEM due to comment in boldmenuitem.h

I've set the install of the Russian keyboard as default since I believe those speakers are the main users in this apps. I didn't define USE_BOLD_MENUITEM due to comment in boldmenuitem.h
Ghost hat das Label PR/rfc vor 6 Jahren hinzugefügt
MicheleC hat vor 6 Jahren kommentiert
Besitzer

I think the default should be english, as for the whole TDE. Russian users can then change their settings

I think the default should be english, as for the whole TDE. Russian users can then change their settings
SlavekB hat vor 6 Jahren kommentiert
Besitzer

Using USE_BOLD_MENUITEM is really "interesting" when the appropriate CPP file starts #undef USE_BOLD_MENUITEM. You're right, we obviously do not need this option.

The fixed definition of TDE_VERSION_MAJOR in config.h is incorrect. This value is defined in tdeversion.h in tdelibs.

The message "xkbfile is requested ..." in ConfigureChecks.cmake would probably be "xkbfile is required ...".

The definition WITH_RU_UA_LAYOUT is inconsistent. Either should be in the "optional stuff" section and be set by WITH_ALL_OPTIONS or should be named BUILD_RU_UA_LAYOUT. In my opinion, the first option is better. By the way, for automake, the default was "disabled". For CMake, it might also be the default OFF.

Using USE_BOLD_MENUITEM is really "interesting" when the appropriate CPP file starts `#undef USE_BOLD_MENUITEM`. You're right, we obviously do not need this option. The fixed definition of TDE_VERSION_MAJOR in `config.h` is incorrect. This value is defined in `tdeversion.h` in tdelibs. The message "xkbfile is requested ..." in `ConfigureChecks.cmake` would probably be "xkbfile is required ...". The definition WITH_RU_UA_LAYOUT is inconsistent. Either should be in the "optional stuff" section and be set by WITH_ALL_OPTIONS or should be named BUILD_RU_UA_LAYOUT. In my opinion, the first option is better. By the way, for automake, the default was "disabled". For CMake, it might also be the default OFF.
Ghost hat vor 6 Jahren kommentiert
Ersteller

@Michele, I meant, I've set to install the Russian layout in the default install as Slavek have pointed out this layout is built as an option with automake.

@Michele, I meant, I've set to install the Russian layout in the default install as Slavek have pointed out this layout is built as an option with automake.
MicheleC hat vor 6 Jahren kommentiert
Besitzer

@Greg: no problem, mine was just a comment from a "not-well-informed" general point of view.

I will leave it to you and Slavek to work out the details 😉

@Greg: no problem, mine was just a comment from a "not-well-informed" general point of view.<br> I will leave it to you and Slavek to work out the details :wink:
SlavekB hat vor 6 Jahren kommentiert
Besitzer

I did squash @cethyel commits for cmake conversion and added two small ones. The scripts for tdeconf_update were not installed as programs => executable bit was not set during installation. At the same time, these scripts in source code have set executable bit unnecessarily.

I did squash @cethyel commits for cmake conversion and added two small ones. The scripts for tdeconf_update were not installed as programs => executable bit was not set during installation. At the same time, these scripts in source code have set executable bit unnecessarily.
SlavekB hat das Label PR/rfc vor 6 Jahren entfernt
SlavekB hat diesen Pull-Request vor 6 Jahren geschlossen
SlavekB löschte die Branch feat/cmakeConv vor 6 Jahren
SlavekB hat diesen Issue vor 6 Jahren zum R14.0.6 release Meilenstein hinzugefügt
Der Pull Request wurde als 03a86cbd51 gemergt.
Anmelden, um an der Diskussion teilzunehmen.
Keine Reviewer
Kein Meilenstein
Niemand zuständig
3 Beteiligte
Nachrichten
Fällig am

Kein Fälligkeitsdatum gesetzt.

Abhängigkeiten

Keine Abhängigkeiten gesetzt.

Referenz: TDE/kkbswitch#1
Laden…
Hier gibt es bis jetzt noch keinen Inhalt.