cmake conversion #1

Unito
SlavekB ha unito 1 commit da feat/cmakeConv a master 6 anni fa
Ghost 6 anni fa ha commentato

I've set the install of the Russian keyboard as default since I believe those speakers are the main users in this apps.

I didn't define USE_BOLD_MENUITEM due to comment in boldmenuitem.h

I've set the install of the Russian keyboard as default since I believe those speakers are the main users in this apps. I didn't define USE_BOLD_MENUITEM due to comment in boldmenuitem.h
Ghost ha aggiunto l'etichetta PR/rfc 6 anni fa
MicheleC 6 anni fa ha commentato
Proprietario

I think the default should be english, as for the whole TDE. Russian users can then change their settings

I think the default should be english, as for the whole TDE. Russian users can then change their settings
SlavekB 6 anni fa ha commentato
Proprietario

Using USE_BOLD_MENUITEM is really "interesting" when the appropriate CPP file starts #undef USE_BOLD_MENUITEM. You're right, we obviously do not need this option.

The fixed definition of TDE_VERSION_MAJOR in config.h is incorrect. This value is defined in tdeversion.h in tdelibs.

The message "xkbfile is requested ..." in ConfigureChecks.cmake would probably be "xkbfile is required ...".

The definition WITH_RU_UA_LAYOUT is inconsistent. Either should be in the "optional stuff" section and be set by WITH_ALL_OPTIONS or should be named BUILD_RU_UA_LAYOUT. In my opinion, the first option is better. By the way, for automake, the default was "disabled". For CMake, it might also be the default OFF.

Using USE_BOLD_MENUITEM is really "interesting" when the appropriate CPP file starts `#undef USE_BOLD_MENUITEM`. You're right, we obviously do not need this option. The fixed definition of TDE_VERSION_MAJOR in `config.h` is incorrect. This value is defined in `tdeversion.h` in tdelibs. The message "xkbfile is requested ..." in `ConfigureChecks.cmake` would probably be "xkbfile is required ...". The definition WITH_RU_UA_LAYOUT is inconsistent. Either should be in the "optional stuff" section and be set by WITH_ALL_OPTIONS or should be named BUILD_RU_UA_LAYOUT. In my opinion, the first option is better. By the way, for automake, the default was "disabled". For CMake, it might also be the default OFF.
Ghost 6 anni fa ha commentato
Autore

@Michele, I meant, I've set to install the Russian layout in the default install as Slavek have pointed out this layout is built as an option with automake.

@Michele, I meant, I've set to install the Russian layout in the default install as Slavek have pointed out this layout is built as an option with automake.
MicheleC 6 anni fa ha commentato
Proprietario

@Greg: no problem, mine was just a comment from a "not-well-informed" general point of view.

I will leave it to you and Slavek to work out the details 😉

@Greg: no problem, mine was just a comment from a "not-well-informed" general point of view.<br> I will leave it to you and Slavek to work out the details :wink:
SlavekB 6 anni fa ha commentato
Proprietario

I did squash @cethyel commits for cmake conversion and added two small ones. The scripts for tdeconf_update were not installed as programs => executable bit was not set during installation. At the same time, these scripts in source code have set executable bit unnecessarily.

I did squash @cethyel commits for cmake conversion and added two small ones. The scripts for tdeconf_update were not installed as programs => executable bit was not set during installation. At the same time, these scripts in source code have set executable bit unnecessarily.
SlavekB rimosso l'etichetta PR/rfc 6 anni fa
SlavekB chiusa questa pull request 6 anni fa
SlavekB branch feat/cmakeConv eliminato 6 anni fa
SlavekB aggiunta alle pietre miliari R14.0.6 release 6 anni fa
La pull request è stata unita come 03a86cbd51.
Effettua l'accesso per partecipare alla conversazione.
Nessun revisore
Nessuna milestone
Nessuna assegnatario
3 Partecipanti
Notifiche
Data di scadenza

Nessuna data di scadenza impostata.

Dipendenze

Nessuna dipendenza impostata.

Riferimento: TDE/kkbswitch#1
Caricamento…
Non ci sono ancora contenuti.