cmake conversion #1

マージ済み
SlavekB が 1 個のコミットを feat/cmakeConv から master へマージ 6年前
Ghost6年前 にコメント

I've set the install of the Russian keyboard as default since I believe those speakers are the main users in this apps.

I didn't define USE_BOLD_MENUITEM due to comment in boldmenuitem.h

I've set the install of the Russian keyboard as default since I believe those speakers are the main users in this apps. I didn't define USE_BOLD_MENUITEM due to comment in boldmenuitem.h
Ghost がラベル PR/rfc を追加 6年前
MicheleC6年前 にコメント
オーナー

I think the default should be english, as for the whole TDE. Russian users can then change their settings

I think the default should be english, as for the whole TDE. Russian users can then change their settings
SlavekB6年前 にコメント
オーナー

Using USE_BOLD_MENUITEM is really "interesting" when the appropriate CPP file starts #undef USE_BOLD_MENUITEM. You're right, we obviously do not need this option.

The fixed definition of TDE_VERSION_MAJOR in config.h is incorrect. This value is defined in tdeversion.h in tdelibs.

The message "xkbfile is requested ..." in ConfigureChecks.cmake would probably be "xkbfile is required ...".

The definition WITH_RU_UA_LAYOUT is inconsistent. Either should be in the "optional stuff" section and be set by WITH_ALL_OPTIONS or should be named BUILD_RU_UA_LAYOUT. In my opinion, the first option is better. By the way, for automake, the default was "disabled". For CMake, it might also be the default OFF.

Using USE_BOLD_MENUITEM is really "interesting" when the appropriate CPP file starts `#undef USE_BOLD_MENUITEM`. You're right, we obviously do not need this option. The fixed definition of TDE_VERSION_MAJOR in `config.h` is incorrect. This value is defined in `tdeversion.h` in tdelibs. The message "xkbfile is requested ..." in `ConfigureChecks.cmake` would probably be "xkbfile is required ...". The definition WITH_RU_UA_LAYOUT is inconsistent. Either should be in the "optional stuff" section and be set by WITH_ALL_OPTIONS or should be named BUILD_RU_UA_LAYOUT. In my opinion, the first option is better. By the way, for automake, the default was "disabled". For CMake, it might also be the default OFF.
Ghost6年前 にコメント
投稿者

@Michele, I meant, I've set to install the Russian layout in the default install as Slavek have pointed out this layout is built as an option with automake.

@Michele, I meant, I've set to install the Russian layout in the default install as Slavek have pointed out this layout is built as an option with automake.
MicheleC6年前 にコメント
オーナー

@Greg: no problem, mine was just a comment from a "not-well-informed" general point of view.

I will leave it to you and Slavek to work out the details 😉

@Greg: no problem, mine was just a comment from a "not-well-informed" general point of view.<br> I will leave it to you and Slavek to work out the details :wink:
SlavekB6年前 にコメント
オーナー

I did squash @cethyel commits for cmake conversion and added two small ones. The scripts for tdeconf_update were not installed as programs => executable bit was not set during installation. At the same time, these scripts in source code have set executable bit unnecessarily.

I did squash @cethyel commits for cmake conversion and added two small ones. The scripts for tdeconf_update were not installed as programs => executable bit was not set during installation. At the same time, these scripts in source code have set executable bit unnecessarily.
SlavekB がラベル PR/rfc を除去 6年前
SlavekB がプルリクエストをクローズ 6年前
SlavekB がブランチ feat/cmakeConv を削除 6年前
SlavekB がマイルストーン R14.0.6 release に追加 6年前
プルリクエストは 03a86cbd51 でマージされています。
サインインしてこの会話に参加。
レビューアなし
マイルストーンなし
担当者なし
3 人の参加者
通知
期日

期日は未設定です。

依存関係

依存関係が設定されていません。

リファレンス: TDE/kkbswitch#1
読み込み中…
まだ内容がありません