cmake conversion #1

已合併
SlavekB 6 年之前 將 1 次代碼提交從 feat/cmakeConv 合併至 master

I've set the install of the Russian keyboard as default since I believe those speakers are the main users in this apps.

I didn't define USE_BOLD_MENUITEM due to comment in boldmenuitem.h

I've set the install of the Russian keyboard as default since I believe those speakers are the main users in this apps. I didn't define USE_BOLD_MENUITEM due to comment in boldmenuitem.h
Ghost added the PR/rfc label 6 年之前
所有者

I think the default should be english, as for the whole TDE. Russian users can then change their settings

I think the default should be english, as for the whole TDE. Russian users can then change their settings
所有者

Using USE_BOLD_MENUITEM is really "interesting" when the appropriate CPP file starts #undef USE_BOLD_MENUITEM. You're right, we obviously do not need this option.

The fixed definition of TDE_VERSION_MAJOR in config.h is incorrect. This value is defined in tdeversion.h in tdelibs.

The message "xkbfile is requested ..." in ConfigureChecks.cmake would probably be "xkbfile is required ...".

The definition WITH_RU_UA_LAYOUT is inconsistent. Either should be in the "optional stuff" section and be set by WITH_ALL_OPTIONS or should be named BUILD_RU_UA_LAYOUT. In my opinion, the first option is better. By the way, for automake, the default was "disabled". For CMake, it might also be the default OFF.

Using USE_BOLD_MENUITEM is really "interesting" when the appropriate CPP file starts `#undef USE_BOLD_MENUITEM`. You're right, we obviously do not need this option. The fixed definition of TDE_VERSION_MAJOR in `config.h` is incorrect. This value is defined in `tdeversion.h` in tdelibs. The message "xkbfile is requested ..." in `ConfigureChecks.cmake` would probably be "xkbfile is required ...". The definition WITH_RU_UA_LAYOUT is inconsistent. Either should be in the "optional stuff" section and be set by WITH_ALL_OPTIONS or should be named BUILD_RU_UA_LAYOUT. In my opinion, the first option is better. By the way, for automake, the default was "disabled". For CMake, it might also be the default OFF.
發佈者

@Michele, I meant, I've set to install the Russian layout in the default install as Slavek have pointed out this layout is built as an option with automake.

@Michele, I meant, I've set to install the Russian layout in the default install as Slavek have pointed out this layout is built as an option with automake.
所有者

@Greg: no problem, mine was just a comment from a "not-well-informed" general point of view.

I will leave it to you and Slavek to work out the details 😉

@Greg: no problem, mine was just a comment from a "not-well-informed" general point of view.<br> I will leave it to you and Slavek to work out the details :wink:
所有者

I did squash @cethyel commits for cmake conversion and added two small ones. The scripts for tdeconf_update were not installed as programs => executable bit was not set during installation. At the same time, these scripts in source code have set executable bit unnecessarily.

I did squash @cethyel commits for cmake conversion and added two small ones. The scripts for tdeconf_update were not installed as programs => executable bit was not set during installation. At the same time, these scripts in source code have set executable bit unnecessarily.
SlavekB removed the PR/rfc label 6 年之前
SlavekB closed this pull request 6 年之前
SlavekB 刪除分支 feat/cmakeConv 6 年之前
SlavekB 新增至R14.0.6 release 里程碑 6 年之前
The pull request has been merged as 03a86cbd51.
登入 才能加入這對話。
No reviewers
未選擇里程碑
No Assignees
3 參與者
訊息
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/kkbswitch#1
Loading…
尚未有任何內容