Labels Milestones

cmake conversion #1

Merged

SlavekB merged 1 commits from feat/cmakeConv into master 6 years ago

Conversation 1 Commits 1 Files Changed 55

Ghost commented 6 years ago

I've added a man page taken from your Debian packaging repository.

There's two "doc" folders in this package, one is empty.

I suggest that the empty one be filled with the content of the other (in src) and then we delete that one in src...or the other way around but we just keep one "doc" folder.

I've added a man page taken from your Debian packaging repository. There's two "doc" folders in this package, one is empty. I suggest that the empty one be filled with the content of the other (in src) and then we delete that one in src...or the other way around but we just keep one "doc" folder.

Ghost added the PR/rfc label 6 years ago

SlavekB commented 6 years ago

Owner

I tested the cmake conversion - it looks very good - I have no objections.

The directory structure seems to be totally strange - inside src directory is ... the src directory! Here we have to make a thorough change of the directory structure. Therefore, it seems that a change in directory structure deserves a separate pull-request and there is no reason to block this pull-request for CMake conversion.

I tested the cmake conversion - it looks very good - I have no objections. The directory structure seems to be totally strange - inside `src` directory is ... the `src` directory! Here we have to make a thorough change of the directory structure. Therefore, it seems that a change in directory structure deserves a separate pull-request and there is no reason to block this pull-request for CMake conversion.

SlavekB removed the PR/rfc label 6 years ago

SlavekB closed this pull request 6 years ago

SlavekB deleted branch feat/cmakeConv 6 years ago

SlavekB added this to the R14.0.6 release milestone 6 years ago

The pull request has been merged as eeefa496af.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce

No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme

Milestone

Set milestone

Clear milestone

No items

No Milestone

R14.0.6 release

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/knetstats#1

Write Preview

Loading…

Cancel

Save

There is no content yet.