TDE
/
knights
6
0
Förgrening 0
Kod Ärenden Pull-förfrågningar Släpp Wiki Aktiviteter
Etiketter Milstenar

cmake conversion #2

Sammanfogat
SlavekB sammanfogade 1 incheckningar från feat/cmakeConv in i master 5 år sedan
Konversation 1 Incheckningar 1 Ändrade Filer 5
Ghost kommenterad 5 år sedan

I've added a man page taken from your Debian packaging system.
I've also made two folders in doc (en, fr) and put the help pages in them.

I've added a man page taken from your Debian packaging system. I've also made two folders in doc (en, fr) and put the help pages in them.
SlavekB granskad av 5 år sedan
SlavekB lämnade en kommentar
Ägare

It looks good. Please make a minor edit of the bug report mentioned below.

Regarding the way for work with tarballs, you do not have to deal with this at this point.

Testing from my side will only be done later.

It looks good. Please make a minor edit of the bug report mentioned below. Regarding the way for work with tarballs, you do not have to deal with this at this point. Testing from my side will only be done later.
ConfigureChecks.cmake Outdated
pkg_search_module( ARTS arts )
if( NOT ARTS_FOUND )
message( FATAL_ERROR "\naRts is requested, but was not found on your system" )
SlavekB kommenterad 5 år sedan
Ägare

Instead of message( FATAL_ERROR … ) would be good to use tde_message_fatal( … ). In this case, then message without an initial \n.

Since arts is not subject to a choice like WITH_ARTS option, then required rather than requested is better.

Instead of `message( FATAL_ERROR … )` would be good to use `tde_message_fatal( … )`. In this case, then message without an initial `\n`. Since `arts` is not subject to a choice like WITH_ARTS option, then *required* rather than *requested* is better.
media/CMakeLists.txt
KBDefault.tar.gz
KSDefault.tar.gz
KCDefault.tar.gz
SlavekB kommenterad 5 år sedan
Ägare

Ha, another module where tarballs are part of the source code!

I suppose there will also be a good idea to unpack content and create tarballs during building… as we solved it in Quanta – see TDE/tdewebdev#3. In this case, it may be a good reason to move the tde_create_tarball macro to a common cmake module.

Ha, another module where tarballs are part of the source code! I suppose there will also be a good idea to unpack content and create tarballs during building… as we solved it in Quanta – see TDE/tdewebdev#3. In this case, it may be a good reason to move the [`tde_create_tarball`](../tdewebdev/src/commit/92ba2fb52a9c257eb9f21619c51eb225b7af7d73/quanta/data/toolbars/CMakeLists.txt#L17) macro to a common cmake module.
po/es.po
"Language-Team: LANGUAGE <LL@li.org>\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=CHARSET\n"
"Content-Type: text/plain; charset=UTF-8\n"
SlavekB kommenterad 5 år sedan
Ägare

Thanks for this fix.

Thanks for this fix.
SlavekB kommenterad 5 år sedan
Ägare

I have made several changes to the build rules for documentation:

  1. Added the CMake rule for installing English documentation – it was missing in your conversion.
  2. Edited the automake rules to install the documentation from the subdirectories – automake builds so far will be functional.
  3. Removed the French documentation because it contains nothing. I found that the nasty formatting of this documentation was because of the preparation for using the poxml tool to translate documentation using PO files. I tested that we would probably use po4a instead of the poxml tool in the future.
I have made several changes to the build rules for documentation: 1. Added the CMake rule for installing English documentation – it was missing in your conversion. 2. Edited the automake rules to install the documentation from the subdirectories – automake builds so far will be functional. 3. Removed the French documentation because it contains nothing. I found that the nasty formatting of this documentation was because of the preparation for using the poxml tool to translate documentation using PO files. I tested that we would probably use po4a instead of the poxml tool in the future.
SlavekB closed this pull request 5 år sedan
SlavekB tog bort grenen feat/cmakeConv 5 år sedan
SlavekB lade till denna till milstolpe R14.0.6 release 5 år sedan
Pull-förfrågan har sammanfogats som bd2ad7db31.
Logga in för att delta i denna konversation.
Granskare
Begär granskning
Inga granskare
Etiketter
Tillämpa etiketter
Rensa etiketter
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
Ingen Etikett GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milsten
Ange milstolpe
Rensa milstenar
Inga objekt
Ingen Milsten
R14.0.6 release
Tilldelade
Tilldela användare
Rensa tilldelade
Ingen tilldelad
2 Deltagare
Notiser
Förfallodatum

Inget förfallodatum satt.

Beroenden

No dependencies set.

Reference: TDE/knights#2
Skriv Förhandsgranska
Laddar…
Avbryt
Spara
Det finns inget innehåll än.
Ta bort branch 'feat/cmakeConv'

Borttagning utav en branch är permanent. Detta KAN INTE ångras. Vill du fortsätta?

Nej
Ja