#2 cmake conversion

Merged
SlavekB merged 5 commits from feat/cmakeConv into master 7 months ago
cethyel commented 7 months ago
There is no content yet.
cethyel added the
PR/wip
label 7 months ago
SlavekB commented 7 months ago
Owner

Probably inadvertently, some files for CMake had a set executable flag. Corrected.

At the same time I prepared patches for TQT_NO_COMPAT and TQT_NO_ASCII_CAST. It’s nice to see that turning these definitions off signifies that something is wrong in the code :smile:

Probably inadvertently, some files for CMake had a set executable flag. Corrected. At the same time I prepared patches for TQT_NO_COMPAT and TQT_NO_ASCII_CAST. It's nice to see that turning these definitions off signifies that something is wrong in the code :smile:
cethyel commented 7 months ago
Poster

I did notice the flags on these 3 files when I committed, git displayed them with chmod 755 and then I asked myself, Is it normal behavior? Let’s push, see what Slavek will say.

It must have happen because I used these files to build the apps, I’ll change that for a copy next time or check for that execute bit.

I did notice the flags on these 3 files when I committed, git displayed them with chmod 755 and then I asked myself, Is it normal behavior? Let's push, see what Slavek will say. It must have happen because I used these files to build the apps, I'll change that for a copy next time or check for that execute bit.
SlavekB commented 7 months ago
Owner

Everything seems to be ready to merge.

Everything seems to be ready to merge.
SlavekB removed the
PR/wip
label 7 months ago
SlavekB commented 7 months ago
Owner

Merged and pushed upstream.

Merged and pushed upstream.
SlavekB deleted branch feat/cmakeConv 7 months ago
SlavekB added this to the R14.0.6 release milestone 7 months ago
The pull request has been merged.
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.