Labels Mijlpalen

cmake conversion #2

Samengevoegd

SlavekB heeft 1 commits samengevoegd van feat/cmakeConv naar master 6 jaren geleden

Discussie 4 Commits 1 Bestanden gewijzigd 3

Ghost commented 6 jaren geleden

Er is nog geen inhoud.

Ghost voegde het PR/wip label 6 jaren geleden toe

SlavekB commented 6 jaren geleden

Eigenaar

Probably inadvertently, some files for CMake had a set executable flag. Corrected.

At the same time I prepared patches for TQT_NO_COMPAT and TQT_NO_ASCII_CAST. It's nice to see that turning these definitions off signifies that something is wrong in the code 😄

Probably inadvertently, some files for CMake had a set executable flag. Corrected. At the same time I prepared patches for TQT_NO_COMPAT and TQT_NO_ASCII_CAST. It's nice to see that turning these definitions off signifies that something is wrong in the code :smile:

Ghost commented 6 jaren geleden

Poster

I did notice the flags on these 3 files when I committed, git displayed them with chmod 755 and then I asked myself, Is it normal behavior? Let's push, see what Slavek will say.

It must have happen because I used these files to build the apps, I'll change that for a copy next time or check for that execute bit.

I did notice the flags on these 3 files when I committed, git displayed them with chmod 755 and then I asked myself, Is it normal behavior? Let's push, see what Slavek will say. It must have happen because I used these files to build the apps, I'll change that for a copy next time or check for that execute bit.

SlavekB commented 6 jaren geleden

Eigenaar

Everything seems to be ready to merge.

Everything seems to be ready to merge.

SlavekB verwijderde het PR/wip label 6 jaren geleden

SlavekB heeft deze pull request gesloten 6 jaren geleden

SlavekB commented 6 jaren geleden

Eigenaar

Merged and pushed upstream.

Merged and pushed upstream.

SlavekB heeft 6 jaren geleden de branch feat/cmakeConv verwijderd.

SlavekB heeft dit 6 jaren geleden aan de mijlpaal R14.0.6 release toegevoegd

De pull request is samengevoegd als 5c55403336.

Log in om deel te nemen aan deze discussie.

Reviewers

Beoordeling aanvragen

Geen beoordelaars

Labels

Labels toepassen

Verwijder labels

GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce

Geen label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme

Mijlpaal

Stel mijlpaal in

Verwijder mijlpaal

Geen items

Geen mijlpaal

R14.0.6 release

Toegewezen aan

Gebruikers toewijzen

Verwijder toegewezen aan

Niet toegewezen

2 deelnemers

Notificaties

Abonneren

Vervaldatum

De deadline is ongeldig of buiten bereik. Gebruik het formaat 'jjjj-mm-dd'.

Geen vervaldatum ingesteld.

Afhankelijkheden

Geen afhankelijkheden ingesteld.

Referentie: TDE/knmap#2

Schrijf Voorbeeld

Laden…

Annuleren

Opslaan

Er is nog geen inhoud.