TDE
/
knowit
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

issue6: Fix icon in desktop file #7

Merged
SlavekB merged 1 commits from ftbfs/invalid_icon_in_desktop_file into master 3 years ago
Conversation 3 Commits 1 Files Changed 1
Francois commented 3 years ago
Collaborator

#6

https://mirror.git.trinitydesktop.org/gitea/TDE/knowit/issues/6
Francois added 1 commit 3 years ago
MicheleC commented 3 years ago
Owner

Hi @Francois, good to see so many PRs from you.
Could you please update the commit with the sign-off clause (git commit -s) and force push the commits to the same branch?

I will comment just on this one, but the same applies for your other PRs you have submitted recently.

Thanks!

Hi @Francois, good to see so many PRs from you. Could you please update the commit with the sign-off clause (git commit -s) and force push the commits to the same branch? I will comment just on this one, but the same applies for your other PRs you have submitted recently. Thanks!
Francois force-pushed ftbfs/invalid_icon_in_desktop_file from 8d2a26be58 to b4e76d7d17 3 years ago
MicheleC commented 3 years ago
Owner

Great, thanks a lot!

Great, thanks a lot!
SlavekB commented 3 years ago
Owner

Because this commit resolves issue #6, there would be good to add into commit log: "This resolves issue #6." This ensures automatic information about binding between Issue and Pull-Request in TGW and also generating a link in the detailed changelog on wiki.

Because this commit resolves issue #6, there would be good to add into commit log: "This resolves issue #6." This ensures automatic information about binding between Issue and Pull-Request in TGW and also generating a link in the detailed changelog on wiki.
Francois force-pushed ftbfs/invalid_icon_in_desktop_file from b4e76d7d17 to f417ea8e1e 3 years ago
SlavekB approved these changes 3 years ago
SlavekB left a comment
Owner

I don't remember what was a motivation for changing the icon during CMake conversion, but PR looks good.

I don't remember what was a motivation for changing the icon during CMake conversion, but PR looks good.
SlavekB merged commit f417ea8e1e into master 3 years ago
SlavekB deleted branch ftbfs/invalid_icon_in_desktop_file 3 years ago
SlavekB added this to the R14.0.11 release milestone 3 years ago

Reviewers

SlavekB approved these changes 3 years ago
The pull request has been merged as f417ea8e1e.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.11 release
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Blocks
#6 Build issue: invalid icon in 'knowit.desktop'
TDE/knowit
Reference: TDE/knowit#7
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'ftbfs/invalid_icon_in_desktop_file'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes