Added build fix for with new version of libpaper #30

Added explicit variable type casting, for compatibility with new versions of the libpaper library.

Hi @ormorph,
looking at the source code in github for libpaper, systempapername() already returns a char*. Nothing wrong with the explicit cast, but why is it suddenly required?

https://github.com/rrthomas/libpaper
fork? libpaper2?
It change systempapername() to return const char*.

How about to change char *paperName to const char *paperName instead?
It never changed here and following paperinfo(paperName) also accept const char*.

Ah thanks, I think I had look at a different github libpaper repository (maybe a fork??).

How about to change char *paperName to const char paperName instead?
It never changed here and following paperinfo(paperName) also accept const char.

Sounds even better!

Hi @ormorph,
looking at the source code in github for libpaper, systempapername() already returns a char*. Nothing wrong with the explicit cast, but why is it suddenly required?

In my Gentoo kword build ended with an error:

invalid conversion from «const char*» to «char*» [-fpermissive]

Although I myself don’t understand why this happened, since the function is declared as exern "C" in the header file.
I am attaching an archive with header files for different versions of libpaper. On version 1.1.28, the assembly runs without errors, and on version 2.0.4, errors appear. The difference is in the macros, since in one case a representation without const is used.

paper.tar.gz

2.1 KiB

How about to change char *paperName to const char *paperName instead?

It will be necessary to check how it all works.

How about to change char *paperName to const char *paperName instead?

It will be necessary to check how it all works.

Good point, I didn't think about older distros that come with older version of libpaper. In view of that, the current patch is probably a safer approach.

Good point, I didn't think about older distros that come with older version of libpaper. In view of that, the current patch is probably a safer approach.

Sorry, ignore my previous comment. Clearly my brain wasn't working!
If we change paperName from char* to const char*, it would work with both old and new version of systempapername()

If we change paperName from char* to const char*, it would work with both old and new version of systempapername()

Yes it works. I did not pay attention that this variable is needed only for paperinfo, of course it will work in all assembly options. Correction added.

Looks good

Added build fix for with new version of libpaper #30

Reviewers