TDE
/
koffice
7
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity
Labels Milestones

Fix kexi build with libpqxx 7 #10

Merged
MicheleC merged 1 commits from :master into master 2 years ago
Conversation 6 Commits 1 Files Changed 1
Francois commented 2 years ago
Collaborator
There is no content yet.
SlavekB commented 2 years ago
Owner

It is required to declare consent to the DCO using a Signed-off-by signature. Please, can you do an amend commit message and do a push using -f?

It is required to declare consent to the DCO using a Signed-off-by signature. Please, can you do an amend commit message and do a push using -f?
Francois commented 2 years ago
Poster
Collaborator

OK I've added the 'signed off by'

OK I've added the 'signed off by'
MicheleC commented 2 years ago
Owner

it may be good to reverse the

#if PQXX_VERSION_MAJOR >= 7

ifdef block, so we use the same condition in both places ==> easier to read

it may be good to reverse the ``` #if PQXX_VERSION_MAJOR >= 7 ``` ifdef block, so we use the same condition in both places ==> easier to read
Francois commented 2 years ago
Poster
Collaborator

OK both tests are identical now

OK both tests are identical now
MicheleC commented 2 years ago
Owner

Great, thanks Francois 😄

Great, thanks Francois :smile:
MicheleC closed this pull request 2 years ago
MicheleC added this to the R14.0.9 release milestone 2 years ago
MicheleC commented 2 years ago
Owner

This resolves bug 3121

This resolves bug [3121](https://bugs.pearsoncomputing.net/show_bug.cgi?id=3121)
The pull request has been merged as 73d1fecdcf.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.9 release
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch ':master'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes