Fix kexi build with libpqxx 7 #10

Merged
MicheleC merged 1 commits from :master into master 2 years ago
Francois commented 2 years ago
Collaborator
There is no content yet.
Owner

It is required to declare consent to the DCO using a Signed-off-by signature. Please, can you do an amend commit message and do a push using -f?

It is required to declare consent to the DCO using a Signed-off-by signature. Please, can you do an amend commit message and do a push using -f?
Poster
Collaborator

OK I've added the 'signed off by'

OK I've added the 'signed off by'
Owner

it may be good to reverse the

#if PQXX_VERSION_MAJOR >= 7

ifdef block, so we use the same condition in both places ==> easier to read

it may be good to reverse the ``` #if PQXX_VERSION_MAJOR >= 7 ``` ifdef block, so we use the same condition in both places ==> easier to read
Poster
Collaborator

OK both tests are identical now

OK both tests are identical now
Owner

Great, thanks Francois 😄

Great, thanks Francois :smile:
MicheleC closed this pull request 2 years ago
MicheleC added this to the R14.0.9 release milestone 2 years ago
Owner

This resolves bug 3121

This resolves bug [3121](https://bugs.pearsoncomputing.net/show_bug.cgi?id=3121)
The pull request has been merged as 73d1fecdcf.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.