TDE
/
koffice
7
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity
Labels Milestones

Fix build on Fedora 34 / Ruby 3.0.1 #11

Merged
MicheleC merged 1 commits from ftbfs/fedora34 into master 1 year ago
Conversation 2 Commits 1 Files Changed 2
Francois commented 1 year ago
Collaborator

File 'ruby/backward/rubysig.h' does not exist anymore.

Signed-off-by: François Andriot francois.andriot@free.fr

File 'ruby/backward/rubysig.h' does not exist anymore. Signed-off-by: François Andriot <francois.andriot@free.fr>
Francois added 1 commit 1 year ago
52df5a2228 Fix build on Fedora 34 / Ruby 3.0.1
SlavekB approved these changes 1 year ago
SlavekB left a comment
Owner

I'm surprised that there is just a small adjustment, but it looks good.

I also tried to do a test on Debian, but here I encountered a problem that C++11 probably is not as default and this fact causes FTBFS. However, for the Debian for now, Ruby 3.x is not a standard part of the distribution, so that a possible problem can be postponed.

I'm surprised that there is just a small adjustment, but it looks good. I also tried to do a test on Debian, but here I encountered a problem that C++11 probably is not as default and this fact causes FTBFS. However, for the Debian for now, Ruby 3.x is not a standard part of the distribution, so that a possible problem can be postponed.
MicheleC commented 1 year ago
Owner

Thanks Francois, it looks good and both Slavek and I are ok to merge this.

Thanks Francois, it looks good and both Slavek and I are ok to merge this.
MicheleC force-pushed ftbfs/fedora34 from 52df5a2228 to e58be56584 1 year ago
MicheleC merged commit e58be56584 into master 1 year ago
MicheleC deleted branch ftbfs/fedora34 1 year ago
MicheleC added this to the R14.0.11 release milestone 1 year ago
MicheleC commented 1 year ago
Owner

Rebased on top of master, merged and backported.

Rebased on top of master, merged and backported.

Reviewers

SlavekB approved these changes 1 year ago
The pull request has been merged as e58be56584.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.11 release
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'ftbfs/fedora34'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes