Fix invalid LDFLAGS in chalk viewplugins #12

Merged
SlavekB merged 1 commits from ftbfs/centos5 into master 1 year ago
Francois commented 1 year ago
Collaborator

This is a very old problem that only happen on CentOS5 (very old), but not on newer distributions.

It looks like there was an incorrect search/replace string in various Makefile.am files.

As you can see, there is a string 'chalkblurfilter_la_LDFLAGS = ' in the middle of another string (e.g; 'chalkshearimage_la_LDFLAGS'). It should not be here.

This is causing FTBFS in CentOS5, which seems normal to me. (But why is it working on other distros ?)

This is a very old problem that only happen on CentOS5 (very old), but not on newer distributions. It looks like there was an incorrect search/replace string in various Makefile.am files. As you can see, there is a string 'chalkblurfilter_la_LDFLAGS = ' in the middle of another string (e.g; 'chalkshearimage_la_LDFLAGS'). It should not be here. This is causing FTBFS in CentOS5, which seems normal to me. (But why is it working on other distros ?)
Francois added 1 commit 1 year ago
SlavekB approved these changes 1 year ago
SlavekB left a comment
Owner

@Francois, very good findings! This problem appears to come before very long time, probably due bad copy && paste – see commit f84d8a2c4e.

It's great that you found it and made a patch.

@Francois, very good findings! This problem appears to come before very long time, probably due bad copy && paste – see commit f84d8a2c4e4058c02f219cd81e6588b4a7abbc58. It's great that you found it and made a patch.
Owner

Please can you update commit and attach your Signed-off-by?

Please can you update commit and attach your `Signed-off-by`?
Francois force-pushed ftbfs/centos5 from 5da216dbd0 to d10645a3b9 1 year ago
SlavekB merged commit d10645a3b9 into master 1 year ago
SlavekB deleted branch ftbfs/centos5 1 year ago
SlavekB added this to the R14.0.11 release milestone 1 year ago

Reviewers

SlavekB approved these changes 1 year ago
The pull request has been merged as d10645a3b9.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.