Labels Milestones

Fix invalid LDFLAGS in chalk viewplugins #12

Merged

SlavekB merged 1 commits from ftbfs/centos5 into master 3 years ago

Conversation 1 Commits 1 Files Changed 15

Francois commented 3 years ago

Collaborator

This is a very old problem that only happen on CentOS5 (very old), but not on newer distributions.

It looks like there was an incorrect search/replace string in various Makefile.am files.

As you can see, there is a string 'chalkblurfilter_la_LDFLAGS = ' in the middle of another string (e.g; 'chalkshearimage_la_LDFLAGS'). It should not be here.

This is causing FTBFS in CentOS5, which seems normal to me. (But why is it working on other distros ?)

This is a very old problem that only happen on CentOS5 (very old), but not on newer distributions. It looks like there was an incorrect search/replace string in various Makefile.am files. As you can see, there is a string 'chalkblurfilter_la_LDFLAGS = ' in the middle of another string (e.g; 'chalkshearimage_la_LDFLAGS'). It should not be here. This is causing FTBFS in CentOS5, which seems normal to me. (But why is it working on other distros ?)

SlavekB approved these changes 3 years ago

SlavekB left a comment

Owner

@Francois, very good findings! This problem appears to come before very long time, probably due bad copy && paste – see commit f84d8a2c4e.

It's great that you found it and made a patch.

@Francois, very good findings! This problem appears to come before very long time, probably due bad copy && paste – see commit f84d8a2c4e4058c02f219cd81e6588b4a7abbc58. It's great that you found it and made a patch.

SlavekB commented 3 years ago

Owner

Please can you update commit and attach your Signed-off-by?

Please can you update commit and attach your `Signed-off-by`?

Francois force-pushed ftbfs/centos5 from 5da216dbd0 to d10645a3b9 3 years ago

SlavekB merged commit d10645a3b9 into master 3 years ago

SlavekB deleted branch ftbfs/centos5 3 years ago

SlavekB added this to the R14.0.11 release milestone 3 years ago

Reviewers

SlavekB approved these changes 3 years ago

The pull request has been merged as d10645a3b9.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

SlavekB

Labels

Apply labels

Clear labels

GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce

No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme

Milestone

Set milestone

Clear milestone

No items

No Milestone

R14.0.11 release

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/koffice#12

Write Preview

Loading…

Cancel

Save

There is no content yet.