Fixed FTBFS caused by usage of dynamic exception specification, no longer accepted in c++17. #13

Merged
MicheleC merged 1 commits from fix/FTBFS-with-c++17 into master 10 months ago
Owner

When building with clang in bullseye, c++17 is used. There was FTBFS due to two problems:

  1. dynamic exception specification, no longer allowed
  2. detection of openexr, due to -fno-exceptions flag being used.

Could you please test it still builds fine in the various distros/archs before we merge?

When building with clang in bullseye, c++17 is used. There was FTBFS due to two problems: 1. dynamic exception specification, no longer allowed 2. detection of openexr, due to -fno-exceptions flag being used. Could you please test it still builds fine in the various distros/archs before we merge?
MicheleC added 1 commit 10 months ago
MicheleC requested review from SlavekB 10 months ago
MicheleC added this to the R14.0.11 release milestone 10 months ago
SlavekB reviewed 10 months ago
SlavekB left a comment
Owner

I didn't do a test, for now, but there is one comment.

I didn't do a test, for now, but there is one comment.
configure.in.in Outdated
OPENEXR_CXXFLAGS="-std=c++$CXX_STD_TEST"
fi
CXXFLAGS="$SAVED_CXXFLAGS $OPENEXR_CFLAGS $OPENEXR_CXXFLAGS"
CXXFLAGS="$SAVED_CXXFLAGS -fexceptions $OPENEXR_CFLAGS $OPENEXR_CXXFLAGS"
Owner

Here it seems to be a good idea to use the variable: $(USE_EXCEPTIONS) which is set according to whether the compiler provides such a flag.

Here it seems to be a good idea to use the variable: `$(USE_EXCEPTIONS)` which is set according to whether the compiler provides such a flag.
Poster
Owner

Amended

Amended
MicheleC marked this conversation as resolved
MicheleC force-pushed fix/FTBFS-with-c++17 from 48e40fb6bb to aa1e0c376e 10 months ago
MicheleC force-pushed fix/FTBFS-with-c++17 from aa1e0c376e to 085b8b6c98 10 months ago
SlavekB approved these changes 10 months ago
SlavekB left a comment
Owner

Successfully tested building on Debian 7.x (Wheezy) and Ubuntu 21.10 (Impish).

Successfully tested building on Debian 7.x (Wheezy) and Ubuntu 21.10 (Impish).
Collaborator

Builds without problems on Slackware64-current.

Builds without problems on Slackware64-current.
MicheleC merged commit 085b8b6c98 into master 10 months ago
MicheleC deleted branch fix/FTBFS-with-c++17 10 months ago
Poster
Owner

Thanks both for testing!

Thanks both for testing!

Reviewers

SlavekB approved these changes 10 months ago
The pull request has been merged as 085b8b6c98.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.