Fix old upstream URLs for visible parts. #3

Merged
MicheleC merged 1 commits from fix/koffice into master 3 years ago
Chris commented 3 years ago
Collaborator

There are still parts existing, but they need a closer look and are unrelated.

This makes KOffice TDE's own. 😃

Signed-off-by: Chris xchrisx@uber.space

There are still parts existing, but they need a closer look and are unrelated. This makes KOffice TDE's own. :smiley: Signed-off-by: Chris <xchrisx@uber.space>
Chris changed title from Fix old upstream URLs for visible parts. to WIP: Fix old upstream URLs for visible parts. 3 years ago
Chris changed title from WIP: Fix old upstream URLs for visible parts. to Fix old upstream URLs for visible parts. 3 years ago
Owner

This is mostly ok, but I have two comments

  1. in karbon/karbon_aboutdata.h there is a new "1998-2006, Kalle Dalheimer..." credit. Is that correct?

  2. in kexi/core/kexiaboutdata.cpp I think we should leave the original author credits and only remove the bug address part.

Can you rework those two files before we merge?

This is mostly ok, but I have two comments 1. in karbon/karbon_aboutdata.h there is a new "1998-2006, Kalle Dalheimer..." credit. Is that correct? 2. in kexi/core/kexiaboutdata.cpp I think we should leave the original author credits and only remove the bug address part. Can you rework those two files before we merge?
Poster
Collaborator

Sure, I did exactly that now. 👍

That with the added copyright came by a mistake. I deleted it by accident and re-added it to the wrong place, it seems.

About kexi:

The link, which is removed, is related to above line. After removing that, the copyrights for openoffice polska, as well the kexi team are still preserved. I don't know. Because it's saying: "This software is developed by..". what is not true anymore. It was, therefore the copyright above. Are sure it should be included? I did re-add it. But you can think again, about that, if you like. 😄

Sure, I did exactly that now. :+1: That with the added copyright came by a mistake. I deleted it by accident and re-added it to the wrong place, it seems. About kexi: The link, which is removed, is related to above line. After removing that, the copyrights for openoffice polska, as well the kexi team are still preserved. I don't know. Because it's saying: "This software is developed by..". what is not true anymore. It *was*, therefore the copyright above. Are sure it should be included? I did re-add it. But you can think again, about that, if you like. :smile:
Owner

Regarding kexi, you have a valid point. I have amended your commit, see if it is ok for you before we merge.

Regarding kexi, you have a valid point. I have amended your commit, see if it is ok for you before we merge.
Poster
Collaborator

It's perfectly fine this way.

It's perfectly fine this way.
MicheleC closed this pull request 3 years ago
MicheleC deleted branch fix/koffice 3 years ago
MicheleC added this to the R14.0.7 release milestone 3 years ago
The pull request has been merged as 9b2c6a2830.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.