Fix old upstream URLs for visible parts. #3
Merged
MicheleC
merged 1 commits from fix/koffice
into master
3 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'fix/koffice'
Deleting a branch is permanent. It CANNOT be undone. Continue?
There are still parts existing, but they need a closer look and are unrelated.
This makes KOffice TDE's own. 😃
Signed-off-by: Chris xchrisx@uber.space
Fix old upstream URLs for visible parts.to WIP: Fix old upstream URLs for visible parts. 3 years agoWIP: Fix old upstream URLs for visible parts.to Fix old upstream URLs for visible parts. 3 years agoThis is mostly ok, but I have two comments
in karbon/karbon_aboutdata.h there is a new "1998-2006, Kalle Dalheimer..." credit. Is that correct?
in kexi/core/kexiaboutdata.cpp I think we should leave the original author credits and only remove the bug address part.
Can you rework those two files before we merge?
Sure, I did exactly that now. 👍
That with the added copyright came by a mistake. I deleted it by accident and re-added it to the wrong place, it seems.
About kexi:
The link, which is removed, is related to above line. After removing that, the copyrights for openoffice polska, as well the kexi team are still preserved. I don't know. Because it's saying: "This software is developed by..". what is not true anymore. It was, therefore the copyright above. Are sure it should be included? I did re-add it. But you can think again, about that, if you like. 😄
Regarding kexi, you have a valid point. I have amended your commit, see if it is ok for you before we merge.
It's perfectly fine this way.
9b2c6a2830
.