TDE
/
konversation
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

Drop automake build support. #3

Merged
MicheleC merged 1 commits from drop/automake into master 1 year ago
Conversation 0 Commits 1 Files Changed 72
MicheleC commented 1 year ago
Owner

As per title.

In deb distros, to be built with TDE/tde-packaging#168.

As per title. In deb distros, to be built with TDE/tde-packaging#168.
MicheleC added this to the R14.1.0 release milestone 1 year ago
MicheleC added 1 commit 1 year ago
73fb0b794e
Drop automake build support.
MicheleC requested review from SlavekB 1 year ago
SlavekB reviewed 1 year ago
SlavekB left a comment
Owner

It looks good. There is only one small comment.

It looks good. There is only one small comment.
INSTALL Outdated
`configure' also accepts some other, not widely useful, options.
-DCMAKE_INSTALL_PREFIX="/opt/trinity" \
SlavekB commented 1 year ago
Owner

Here is not the usual:

konversation relies on cmake to build.

Here are suggested default options:
Here is not the usual: ``` konversation relies on cmake to build. Here are suggested default options: ```
MicheleC commented 1 year ago
Poster
Owner

I had copied the INSTALL file from Kasablanca, which is therefore also missing that suggested part. Likely, some INSTALL files have it, some don't. PR updated as suggested.

I had copied the INSTALL file from Kasablanca, which is therefore also missing that suggested part. Likely, some INSTALL files have it, some don't. PR updated as suggested.
SlavekB commented 1 year ago
Owner

Thank you. We can unify it gradually.

Thank you. We can unify it gradually.
MicheleC marked this conversation as resolved
MicheleC force-pushed drop/automake from 73fb0b794e to 5c73ac2aef 1 year ago
SlavekB approved these changes 1 year ago
SlavekB left a comment
Owner

It looks good.

It looks good.
MicheleC merged commit 5c73ac2aef into master 1 year ago
MicheleC deleted branch drop/automake 1 year ago

Reviewers

SlavekB approved these changes 1 year ago
The pull request has been merged as 5c73ac2aef.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.0 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Blocks
#168 DEB konversation: updated after dropping automake support.
TDE/tde-packaging
Reference: TDE/konversation#3
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'drop/automake'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes