Conversion to the cmake building system. #1
Συγχωνευμένα
SlavekB
συγχώνευσε 4 υποβολές από feat/cmakeConv σε master 3 έτη πριν
SlavekB
Φόρτωση…
Αναφορά σε νέο ζήτημα
Δεν υπάρχει ακόμα περιεχόμενο.
Διαγραφή του Κλάδου 'feat/cmakeConv'
Η διαγραφή του κλάδου είναι μόνιμη. ΔΕΝ ΜΠΟΡΕΙ να αναιρεθεί. Συνέχεια;
Why did you now use
PROPERTY POSITION_INDEPENDENT_CODE ONinstead of the usualSTATIC-PIC?3e04758b8eστο2d90c18ede3 έτη πριν2d90c18edeστοd1e4611e7e3 έτη πριν@SlavekB, please test when you've got time because: First, the way I built It is not a "copy and paste" of the Makefiles, then I fairly don't know how to use kopete...less again kopete-otr 😅
d1e4611e7eστοa9356df5623 έτη πρινsome potential fix:
https://mirror.git.trinitydesktop.org/gitea/TDE/kopete-otr/src/branch/master/src/otrlchatinterface.cpp#L100
icon's name for the animation: kde vs tde
https://mirror.git.trinitydesktop.org/gitea/TDE/kopete-otr/src/branch/master/src/otrlconfinterface.cpp#L118
warning: NULL used in arithmetic: NULL vs 0
It looks good, but there are several comments.
#### general package setupproject( kopete-otr )It looks like everything that is installed is named
kopete_otr(with underscore). So it looks more practical to use an underscore also in the name of the project.pkg_search_module( LIBOTR libotr )if( LIBOTR_FOUND )if( LIBOTR_VERSION VERSION_GREATER 4.0.0 )Attention, this will not be properly evaluated for version 4.0.0 as such. Here it should be:
otrlchatinterface.cppsmppopup.cppverifypopup.cpp${CMAKE_BINARY_DIR}/src/privkeypopupui.cppIt is unusual to add as sources cpp files that are already contained in another library. Here you can omit these files, omit
DEPENDENCIES kotr_gui-staticand instead giveLINK kotr_gui-static.SOURCESotrplugin.cppotrguiclient.cpp${CMAKE_BINARY_DIR}/src/kopete_otr.cppThe same as above.
a9356df562στο61665a20a53 έτη πριν52c2af534aστοc7f7b377513 έτη πρινWIP:Conversion to the cmake building system.σε Conversion to the cmake building system. 3 έτη πρινc7f7b37751στοe6036101ea3 έτη πρινEverything seems well resolved, and that nothing prevents merging.
e6036101eaσε master 3 έτη πρινΕξεταστές
e6036101ea.