FTBFS undefined reference to `PluginUtility::pluginVersion(KLibrary const*)' #1

Basic information

TDE version: R14.1
Distribution: Debian Stretch
Hardware: amd64

Description

Hi,
updated repository today and run a test build. It failed here with the message below

output

/usr/bin/g++  -fPIC -g -O2 -fdebug-prefix-map=/mnt/DEVELOPMENT/TDE/repo-master/tde/2_build/applications/kpilot=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fvisibility=hidden -fvisibility-inlines-hidden  -DTQT_NO_ASCII_CAST -DTQT_NO_STL -DTQT_NO_COMPAT -DTQT_NO_TRANSLATION -DTQT_THREAD_SUPPORT -D_REENTRANT -include tqt.h -I/usr/include/tqt3 -I/usr/include/tqt -DTQT_NO_ASCII_CAST -DTQT_NO_STL -DTQT_NO_COMPAT -DTQT_NO_TRANSLATION -DTQT_THREAD_SUPPORT -D_REENTRANT -include tqt.h -g -Wl,-z,relro -Wl,--no-undefined -shared  -o kcm_kpilot.so CMakeFiles/kcm_kpilot-module.dir/pilotDaemonDCOP_stub.cpp.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigDialog.cc.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigDialog_device.cpp.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigDialog_sync.cpp.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigDialog_startup.cpp.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigDialog_viewers.cpp.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigDialog_backup.cpp.o CMakeFiles/kcm_kpilot-module.dir/conduitConfigDialog.cc.o CMakeFiles/kcm_kpilot-module.dir/kpilotProbeDialog.cc.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigWizard_address.cpp.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigWizard_notes.cpp.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigWizard_vcal.cpp.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigWizard_user.cpp.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigWizard_app.cpp.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigWizard.cc.o CMakeFiles/kcm_kpilot-module.dir/dbSelectionDialog.cc.o CMakeFiles/kcm_kpilot-module.dir/dbSelection_base.cpp.o -Wl,-rpath,/mnt/DEVELOPMENT/TDE/repo-master/tde/2_build/applications/kpilot/obj-x86_64-linux-gnu/lib:/opt/trinity/lib: ../lib/libkpilot.so.0.0.0 libconfiguration.a /opt/trinity/lib/libkcal.so.2.0.0 /opt/trinity/lib/libtdeabc.so.1.2.0 /opt/trinity/lib/libvcard.so.0.0.0 /opt/trinity/lib/libtderesources.so.1.2.0 /opt/trinity/lib/libktnef.so.1.0.0 /opt/trinity/lib/libkmime.so.2.2.0 -lical -licalss -licalvcal -lpthread -lpisock /opt/trinity/lib/libtdeio.so.14.0.0 /opt/trinity/lib/libtdeui.so.14.0.0 -lfreetype -lfontconfig -lXext /opt/trinity/lib/libtdesu.so.14.0.0 /opt/trinity/lib/libtdewalletclient.so.1.0.1 /opt/trinity/lib/libtdecore.so.14.0.0 /opt/trinity/lib/libDCOP.so.14.0.0 /opt/trinity/lib/libtdefx.so.14.0.0 -ltqt -ltqt-mt -lXrender -lX11 -lc -lz -lidn -lXcomposite -lICE -lSM -lutil -lr -lacl -lattr
CMakeFiles/kcm_kpilot-module.dir/conduitConfigDialog.cc.o: In function `dumpConduitInfo':
./obj-x86_64-linux-gnu/kpilot/./kpilot/conduitConfigDialog.cc:470: undefined reference to `PluginUtility::pluginVersion(KLibrary const*)'
./obj-x86_64-linux-gnu/kpilot/./kpilot/conduitConfigDialog.cc:471: undefined reference to `PluginUtility::pluginVersionString(KLibrary const*)'
collect2: error: ld returned 1 exit status
kpilot/CMakeFiles/kcm_kpilot-module.dir/build.make:633: recipe for target 'kpilot/kcm_kpilot.so' failed
make[2]: *** [kpilot/kcm_kpilot.so] Error 1
make[2]: Leaving directory '/mnt/DEVELOPMENT/TDE/repo-master/tde/2_build/applications/kpilot/obj-x86_64-linux-gnu'
CMakeFiles/Makefile2:227: recipe for target 'kpilot/CMakeFiles/kcm_kpilot-module.dir/all' failed
make[1]: *** [kpilot/CMakeFiles/kcm_kpilot-module.dir/all] Error 2
make[1]: Leaving directory '/mnt/DEVELOPMENT/TDE/repo-master/tde/2_build/applications/kpilot/obj-x86_64-linux-gnu'
Makefile:130: recipe for target 'all' failed
make: *** [all] Error 2

## Basic information - TDE version: R14.1 - Distribution: Debian Stretch - Hardware: amd64  ## Description Hi, updated repository today and run a test build. It failed here with the message below ## output ``` /usr/bin/g++ -fPIC -g -O2 -fdebug-prefix-map=/mnt/DEVELOPMENT/TDE/repo-master/tde/2_build/applications/kpilot=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fvisibility=hidden -fvisibility-inlines-hidden -DTQT_NO_ASCII_CAST -DTQT_NO_STL -DTQT_NO_COMPAT -DTQT_NO_TRANSLATION -DTQT_THREAD_SUPPORT -D_REENTRANT -include tqt.h -I/usr/include/tqt3 -I/usr/include/tqt -DTQT_NO_ASCII_CAST -DTQT_NO_STL -DTQT_NO_COMPAT -DTQT_NO_TRANSLATION -DTQT_THREAD_SUPPORT -D_REENTRANT -include tqt.h -g -Wl,-z,relro -Wl,--no-undefined -shared -o kcm_kpilot.so CMakeFiles/kcm_kpilot-module.dir/pilotDaemonDCOP_stub.cpp.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigDialog.cc.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigDialog_device.cpp.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigDialog_sync.cpp.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigDialog_startup.cpp.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigDialog_viewers.cpp.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigDialog_backup.cpp.o CMakeFiles/kcm_kpilot-module.dir/conduitConfigDialog.cc.o CMakeFiles/kcm_kpilot-module.dir/kpilotProbeDialog.cc.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigWizard_address.cpp.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigWizard_notes.cpp.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigWizard_vcal.cpp.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigWizard_user.cpp.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigWizard_app.cpp.o CMakeFiles/kcm_kpilot-module.dir/kpilotConfigWizard.cc.o CMakeFiles/kcm_kpilot-module.dir/dbSelectionDialog.cc.o CMakeFiles/kcm_kpilot-module.dir/dbSelection_base.cpp.o -Wl,-rpath,/mnt/DEVELOPMENT/TDE/repo-master/tde/2_build/applications/kpilot/obj-x86_64-linux-gnu/lib:/opt/trinity/lib: ../lib/libkpilot.so.0.0.0 libconfiguration.a /opt/trinity/lib/libkcal.so.2.0.0 /opt/trinity/lib/libtdeabc.so.1.2.0 /opt/trinity/lib/libvcard.so.0.0.0 /opt/trinity/lib/libtderesources.so.1.2.0 /opt/trinity/lib/libktnef.so.1.0.0 /opt/trinity/lib/libkmime.so.2.2.0 -lical -licalss -licalvcal -lpthread -lpisock /opt/trinity/lib/libtdeio.so.14.0.0 /opt/trinity/lib/libtdeui.so.14.0.0 -lfreetype -lfontconfig -lXext /opt/trinity/lib/libtdesu.so.14.0.0 /opt/trinity/lib/libtdewalletclient.so.1.0.1 /opt/trinity/lib/libtdecore.so.14.0.0 /opt/trinity/lib/libDCOP.so.14.0.0 /opt/trinity/lib/libtdefx.so.14.0.0 -ltqt -ltqt-mt -lXrender -lX11 -lc -lz -lidn -lXcomposite -lICE -lSM -lutil -lr -lacl -lattr CMakeFiles/kcm_kpilot-module.dir/conduitConfigDialog.cc.o: In function `dumpConduitInfo': ./obj-x86_64-linux-gnu/kpilot/./kpilot/conduitConfigDialog.cc:470: undefined reference to `PluginUtility::pluginVersion(KLibrary const*)' ./obj-x86_64-linux-gnu/kpilot/./kpilot/conduitConfigDialog.cc:471: undefined reference to `PluginUtility::pluginVersionString(KLibrary const*)' collect2: error: ld returned 1 exit status kpilot/CMakeFiles/kcm_kpilot-module.dir/build.make:633: recipe for target 'kpilot/kcm_kpilot.so' failed make[2]: *** [kpilot/kcm_kpilot.so] Error 1 make[2]: Leaving directory '/mnt/DEVELOPMENT/TDE/repo-master/tde/2_build/applications/kpilot/obj-x86_64-linux-gnu' CMakeFiles/Makefile2:227: recipe for target 'kpilot/CMakeFiles/kcm_kpilot-module.dir/all' failed make[1]: *** [kpilot/CMakeFiles/kcm_kpilot-module.dir/all] Error 2 make[1]: Leaving directory '/mnt/DEVELOPMENT/TDE/repo-master/tde/2_build/applications/kpilot/obj-x86_64-linux-gnu' Makefile:130: recipe for target 'all' failed make: *** [all] Error 2 ```

Odd, I'm not able to reproduce this on my machine. Please, you can try this patch?

diff --git a/lib/plugin.h b/lib/plugin.h
index 0432fe5..ddae9fe 100644
--- a/lib/plugin.h
+++ b/lib/plugin.h
@@ -388,7 +388,7 @@ protected:
 } ;

 /** A namespace containing only static helper methods. */
-namespace PluginUtility
+namespace PluginUtility KDE_EXPORT
 {
        /** Searches the argument list for --foo=bar and returns bar, TQString() if not found.
        * Don't include the -- in the argname. */

Confirmed - it builds
thanks

#2 Fix FTBFS due hidden visibility on PluginUtility

solves the issue