TDE
/
kpilot
6
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity
Labels Milestones

Drop automake build support. #7

Merged
MicheleC merged 1 commits from drop/automake into master 1 year ago
Conversation 5 Commits 1 Files Changed 34
MicheleC commented 1 year ago
Owner

As per title.

On deb distros, to be built with TDE/tde-packaging#170

As per title. On deb distros, to be built with TDE/tde-packaging#170
MicheleC added this to the R14.1.0 release milestone 1 year ago
MicheleC added 1 commit 1 year ago
ee5fe0f389
Drop automake build support.
MicheleC requested review from SlavekB 1 year ago
SlavekB approved these changes 1 year ago
SlavekB left a comment
Owner

It looks good.

It looks good.
SlavekB commented 1 year ago
Owner

There seems to be some file Makefile-standalone that can probably be removed as well.

There seems to be some file `Makefile-standalone` that can probably be removed as well.
MicheleC commented 1 year ago
Poster
Owner

There seems to be some file Makefile-standalone that can probably be removed as well.

I thought about it and consider removing it too. But it seems to be an example so in the end I left it there. We can either:

  1. leave it as is
  2. remove
  3. replace with something cmake based, but I don't think it is worth the effort.

What do you think?

> There seems to be some file `Makefile-standalone` that can probably be removed as well. I thought about it and consider removing it too. But it seems to be an example so in the end I left it there. We can either: 1. leave it as is 2. remove 3. replace with something cmake based, but I don't think it is worth the effort. What do you think?
SlavekB commented 1 year ago
Owner

It seems to me that this is a Makefile for building manually – that is, without performing detection and configuration of the build with Automake or CMake. It seems unlikely to me that anyone would need to build in this way. That's why I think it's unnecessary to keep it.

It seems to me that this is a Makefile for building _manually_ – that is, without performing detection and configuration of the build with Automake or CMake. It seems unlikely to me that anyone would need to build in this way. That's why I think it's unnecessary to keep it.
MicheleC force-pushed drop/automake from ee5fe0f389 to e365033d55 1 year ago
MicheleC commented 1 year ago
Poster
Owner

Makefile-standalone has been removed.
I had misunderstood the file you were talking about, I was actually referring to another file Documentation/ConduitProgrammingTutorial/Makefile. This won't work for building, but I think it serves to give an idea about what is needed to do. My previous comment was actually about this file. Should we leave it or remove it?

`Makefile-standalone` has been removed. I had misunderstood the file you were talking about, I was actually referring to another file `Documentation/ConduitProgrammingTutorial/Makefile`. This won't work for building, but I think it serves to give an idea about what is needed to do. My previous comment was actually about this file. Should we leave it or remove it?
SlavekB commented 1 year ago
Owner

Ah, I see, I didn't notice this file. Since this documentation was not part of automake and is not yet part of CMake builds, it will be good to keep this Makefile there.

Ah, I see, I didn't notice this file. Since this documentation was not part of automake and is not yet part of CMake builds, it will be good to keep this Makefile there.
👍 1
MicheleC merged commit e365033d55 into master 1 year ago
MicheleC deleted branch drop/automake 1 year ago

Reviewers

SlavekB approved these changes 1 year ago
The pull request has been merged as e365033d55.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.0 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Blocks
#170 DEB kpilot: updated after dropping automake support.
TDE/tde-packaging
Reference: TDE/kpilot#7
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'drop/automake'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes